Preview pane: a late ready kept through a navigation, and a new token on the form's reload

オープン
#3,470 コメント 0 件 リアクション 0 件 担当者 0 名 GitHub で見る

メンテナーはふだん 1 日以内に返信

まだ誰も着手していません。

評価

難易度
4/5
見積もり時間
3〜5日
初心者へのやさしさ
47/100
issue の種類
バグ
明瞭さ
おおむね明確
活発さ
活発
技術スタック
csharp
領域
backend, testing

調査の方向性

Read ContentPreview.razor and its LoadedAsync method, then inspect ContentForm.razor and the existing component tests for both behaviors. Trace how ready state and the pane token change across navigation and form reload; use the tests to check the acceptance cases, including the documented contract limit in section 4.12 if that approach is chosen.

索引モデルが issue の本文から書いたものです。

説明

area:admin type:bug

Problem

Two cases of the preview pane that the review of #3437 (#3403) left for later:

  • A page that says ready after its own load keeps ready through a navigation to a page without the contract. The pane forgets ready when the frame loads a page with no ready since the previous load (ContentPreview.razor, LoadedAsync). For the order load 1, ready 1, load 2 with no ready, the flag is still true from ready 1 when load 2 arrives, so the next save posts refresh to a page that ignores it: nothing reloads and the Silent note never shows. Front ends that post ready after hydration or after a data fetch send it in that order. The rule cannot tell this from a ready that is merely delivered late, which #3403 settled; the component test and the end-to-end case cover only ready before the load.
  • Reloading the form re-creates the open pane, which mints again while its token lasts. ContentForm.razor sets its read to null before the first await of LoadAsync, so the pane's condition turns false and the pane is disposed; when the read ends a new pane mints as it opens. The conflict dialog's Reload and Try again, on the same entry and locale, so give a new token that cannot be revoked and reload the frame.

Proposal

  • Tell the two orders apart, or ask a contract page to post navigated before a full navigation and say so in section 4.12; whichever is chosen, record the limit in 4.12.
  • Keep the pane, its answer and its token across a reload of the same entry, site and locale.

Acceptance

  • A page that says ready after its load and then navigates to a page without the contract is reloaded on the next save, or section 4.12 states the limit and the contract asks for navigated
  • The conflict dialog's Reload and Try again on the same entry and locale mint no token while the shown one lasts
  • Component tests for both, and an end-to-end case for the first if the contract changes

From the second review of #3437 (#3403).

主要言語
C#
スター
567
フォーク
107
平均マージ
1時間 19分
マージ済み PR(30日)
353

環境構築

はじめの一歩

  1. issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
  2. 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
  3. リポジトリをフォークし、ブランチを切って変更します。
  4. issue 番号を参照したプルリクエストを送ります。

fluentcms/FluentCMS のほかの issue

fluentcms/FluentCMS の issue をすべて見る

似ている issue

C# の issue をもっと見る

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。