[Bug] requested_reviewers is null for pull requests that have no reviews yet

Abierto
  • ¿Algo no está bien?
#86 1 comentario 0 reacciones 0 asignados Ver en GitHub

@porkedchop ya está trabajando en esto.

Desde el 5/11/2026.

  • #87 de @porkedchop — abierto

Evaluación

Dificultad
2/5
Tiempo estimado
1-3 horas
Aptitud para principiantes
35/100
Tipo de issue
Error
Claridad
Bien especificado
Estado de actividad
Estancado
Stack tecnológico
sql
Área
data-engineering

Línea de trabajo

Read the int_github__pull_request_reviewers model, especially the joined CTE, and trace how int_github__issue_joined uses pull_request_id to populate github__pull_requests. Reproduce the five seeded cases with open review requests and no submitted reviews, then confirm the expected count changes from 34 to 39 populated requested_reviewers; pull request #87 is already open for this issue.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

Is there an existing issue for this?
  • I have searched the existing issues
Describe the issue

int_github__pull_request_reviewers full outer joins actual_reviewers to requested_reviewers, but selects source_relation and pull_request_id only from actual_reviewers. For a pull request that has requested reviewers but no submitted reviews yet, the row comes from requested_reviewers alone, so pull_request_id and source_relation are null. int_github__issue_joined joins on pull_request_id, so that row never matches and requested_reviewers is null in github__pull_requests. These are the pull requests still waiting on review, which is where the column is most useful.

Relevant error log or model output

With the integration test seeds, 5 pull requests have an open review request and no reviews (for example pull_request_id 408105961, 407401898, 516351583, 521867065, 442423917). All 5 have requested_reviewers = null in github__pull_requests, even though the requested user exists in user. Overall 34 of 167 pull requests have requested_reviewers populated.

Expected behavior

requested_reviewers lists the requested reviewers whether or not anyone has reviewed yet. With the seeds, 39 of 167 pull requests.

Possible solution

Coalesce source_relation and pull_request_id from both sides of the full outer join in the joined CTE. I have a PR ready.

dbt Project configurations

Package integration_tests project.

Package versions

dbt_github 1.5.0 (main)

What database are you using dbt with?

duckdb

How are you running this dbt package?

dbt Core

dbt Version

1.12.6

Are you willing to open a PR to help address this issue?
  • Yes.
Lenguaje dominante
Sin datos de lenguaje
Estrellas
21
Forks
25
Merge medio
1 d 41 min
PR fusionados (30 d)
2

Preparar el entorno

  • Sin Dockerfile ni archivo de Docker Compose
  • Tiene una plantilla de pull request
  • Sin guía de contribución

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de fivetran/dbt_github

Todos los issues de fivetran/dbt_github

Issues similares

Más issues de Data Engineering

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.