[Bug] requested_reviewers is null for pull requests that have no reviews yet
评估
- 难度
- 2/5
- 预计耗时
- 1-3 小时
- 新手友好度
- 35/100
- Issue 类型
- 缺陷
- 描述清晰度
- 描述清楚
- 活跃度
- 停滞
- 技术栈
- sql
调研方向
Read the int_github__pull_request_reviewers model, especially the joined CTE, and trace how int_github__issue_joined uses pull_request_id to populate github__pull_requests. Reproduce the five seeded cases with open review requests and no submitted reviews, then confirm the expected count changes from 34 to 39 populated requested_reviewers; pull request #87 is already open for this issue.
由索引模型根据 Issue 内容生成。
描述
Is there an existing issue for this?
- I have searched the existing issues
Describe the issue
int_github__pull_request_reviewers full outer joins actual_reviewers to requested_reviewers, but selects source_relation and pull_request_id only from actual_reviewers. For a pull request that has requested reviewers but no submitted reviews yet, the row comes from requested_reviewers alone, so pull_request_id and source_relation are null. int_github__issue_joined joins on pull_request_id, so that row never matches and requested_reviewers is null in github__pull_requests. These are the pull requests still waiting on review, which is where the column is most useful.
Relevant error log or model output
With the integration test seeds, 5 pull requests have an open review request and no reviews (for example pull_request_id 408105961, 407401898, 516351583, 521867065, 442423917). All 5 have requested_reviewers = null in github__pull_requests, even though the requested user exists in user. Overall 34 of 167 pull requests have requested_reviewers populated.
Expected behavior
requested_reviewers lists the requested reviewers whether or not anyone has reviewed yet. With the seeds, 39 of 167 pull requests.
Possible solution
Coalesce source_relation and pull_request_id from both sides of the full outer join in the joined CTE. I have a PR ready.
dbt Project configurations
Package integration_tests project.
Package versions
dbt_github 1.5.0 (main)
What database are you using dbt with?
duckdb
How are you running this dbt package?
dbt Core
dbt Version
1.12.6
Are you willing to open a PR to help address this issue?
- Yes.
- 主要语言
- 没有语言数据
- 星标
- 21
- 派生
- 25
- 平均合并
- 1 天 41 分钟
- 30 天内合并 PR
- 2
环境准备
- 没有 Dockerfile 或 Docker Compose 文件
- 有 Pull Request 模板
- 没有贡献指南
从这里开始
- 先读完整个 Issue，再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库，在一个分支上完成修改。
- 提交 Pull Request，并在描述里引用这个 Issue 编号。
fivetran/dbt_github 的其他 Issue
-
next-release
难度 3/5 1-2 天 新手友好度 35/100
fivetran/dbt_github#74 ·
-
good first issue type:enhancement
难度 5/5 一周以上 新手友好度 35/100
fivetran/dbt_github#61 ·
-
type:enhancement
难度 5/5 一周以上 新手友好度 25/100
fivetran/dbt_github#34 · 1 条评论 ·
-
type:enhancement
难度 4/5 3-5 天 新手友好度 25/100
fivetran/dbt_github#69 · 1 个 reaction ·
-
Add Team support未关闭type:enhancement
难度 5/5 一周以上 新手友好度 30/100
fivetran/dbt_github#70 · 5 条评论 ·
查看 fivetran/dbt_github 的全部 Issue
相似的 Issue
-
ODS datetime imports reject fractional seconds and exports drop them可能已有人在做 @IlyaKhalafi 今天认领。 未关闭
难度 2/5 1-3 小时 新手友好度 70/100
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 72/100
fivetran/dbt_recurly#55 ·
-
难度 2/5 1-3 小时 新手友好度 78/100
TauricResearch/TradingAgents#1693 ·
维护者通常 2 天内回复
-
fuzz fuzz-unconfirmed
难度 2/5 1-3 小时 新手友好度 68/100
维护者通常 1 天内回复
-
[Bug] `dbt compile` fails on a new schema in demographics pivot models可能已有人在做 @fivetran-jamie 今天认领。 未关闭type:bug
难度 2/5 1-3 小时 新手友好度 78/100