[Bug] requested_reviewers is null for pull requests that have no reviews yet

Ouverte
  • Quelque chose ne va pas ?
#86 1 commentaire 0 réactions 0 personnes assignées Voir sur GitHub

@porkedchop y travaille déjà.

Depuis le 5/11/2026.

  • #87 par @porkedchop — ouverte

Évaluation

Difficulté
2/5
Temps estimé
1-3 heures
Accessibilité débutants
35/100
Type d'issue
Bug
Clarté
Clairement spécifiée
Activité
À l'abandon
Stack technique
sql
Domaine
data-engineering

Piste de recherche

Read the int_github__pull_request_reviewers model, especially the joined CTE, and trace how int_github__issue_joined uses pull_request_id to populate github__pull_requests. Reproduce the five seeded cases with open review requests and no submitted reviews, then confirm the expected count changes from 34 to 39 populated requested_reviewers; pull request #87 is already open for this issue.

Rédigé par le modèle d'indexation à partir du texte de l'issue.

Description

Is there an existing issue for this?
  • I have searched the existing issues
Describe the issue

int_github__pull_request_reviewers full outer joins actual_reviewers to requested_reviewers, but selects source_relation and pull_request_id only from actual_reviewers. For a pull request that has requested reviewers but no submitted reviews yet, the row comes from requested_reviewers alone, so pull_request_id and source_relation are null. int_github__issue_joined joins on pull_request_id, so that row never matches and requested_reviewers is null in github__pull_requests. These are the pull requests still waiting on review, which is where the column is most useful.

Relevant error log or model output

With the integration test seeds, 5 pull requests have an open review request and no reviews (for example pull_request_id 408105961, 407401898, 516351583, 521867065, 442423917). All 5 have requested_reviewers = null in github__pull_requests, even though the requested user exists in user. Overall 34 of 167 pull requests have requested_reviewers populated.

Expected behavior

requested_reviewers lists the requested reviewers whether or not anyone has reviewed yet. With the seeds, 39 of 167 pull requests.

Possible solution

Coalesce source_relation and pull_request_id from both sides of the full outer join in the joined CTE. I have a PR ready.

dbt Project configurations

Package integration_tests project.

Package versions

dbt_github 1.5.0 (main)

What database are you using dbt with?

duckdb

How are you running this dbt package?

dbt Core

dbt Version

1.12.6

Are you willing to open a PR to help address this issue?
  • Yes.
Langage dominant
Aucune donnée de langage
Étoiles
21
Forks
25
Merge moyen
1 j 41 min
PR mergées (30 j)
2

Préparer son environnement

  • Aucun Dockerfile ni fichier Docker Compose
  • Propose un modèle de pull request
  • Aucun guide de contribution

Par où commencer

  1. Lisez l'issue en entier, puis le guide de contribution du projet.
  2. Signalez en commentaire que vous la prenez — cela évite que deux personnes fassent le même travail.
  3. Forkez le dépôt et travaillez sur une branche.
  4. Ouvrez une pull request qui référence le numéro de l'issue.

Autres issues de fivetran/dbt_github

Toutes les issues de fivetran/dbt_github

Issues similaires

Plus d'issues Data Engineering

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.