[taskflow] Give hosts a task's read roles so they can check access to its detail
Los mantenedores suelen responder en 1 día
@mushrafmim ya está trabajando en esto.
Desde el 3/11/2026.
Evaluación
Este issue todavía no se ha evaluado.
Descripción
Current Limitation
Taskflow never decides who may read a task, so a host checks access itself. A listing goes through TaskManager.GetTasks with TaskFilter.Roles, which matches the caller's roles against the task's read roles in SQL. A single task's detail, TaskManager.GetTaskRenderInfo(ctx, taskID), checks nothing. frontend-guide.md says the host must first check "that the caller holds one of the task's read roles (TaskRecord.ReadRoles, stored in taskflow_task_roles) in the task's case", because a caller can request any task ID directly.
No TaskManager method lets a host do that check:
TaskView, whichGetTaskRenderInforeturns, has neither the task'sCaseIDnor its read roles.- In the store,
GetTaskandGetTaskByWorkflowIDfill everyTaskRecordfield exceptReadRoles. The roles live intaskflow_task_roles, and theTaskRecorddoc says "the read methods leave this field empty: a host that needs a task's roles reads them where InitTask stored them".
So the only way to do the required check is to query taskflow_task_roles directly. That ties every task-detail endpoint to the table, its columns and its name, outside the TaskManager API that hosts otherwise use. Hosts call TaskManager, not the store, which is the persistence port only the manager calls. A change to the table changes the host without a compile error, and a host that forgets the check exposes every task to anyone who can guess an ID.
Suggested Improvement
-
Store:
GetTaskandGetTaskByWorkflowIDreturnReadRoles, loaded fromtaskflow_task_rolesbytask_id(the leading column of its primary key).GetTaskskeeps leaving it empty, likeData: its role filter already runs in SQL, and a listing doesn't need the roles. -
Hosts: expose the check through
TaskManager, in one of two ways:- a. Match roles in
GetTaskRenderInfo(preferred). The host passes the roles the caller holds, as it does forGetTasks, and taskflow matches them by name, the same rule asTaskFilter.Matches. For example:
It returnsGetTaskRenderInfo(ctx context.Context, taskID string, roles []string) (TaskView, error)ErrTaskNotFound(or a dedicated error) when the caller holds none of the task's read roles. Taskflow still never decides who holds a role. A listing and a detail read then apply the same rule in one place, and the check can't be skipped by forgetting it. As withTaskFilter.Roles, a role the caller holds in only some cases must be passed only for a task in one of those cases; the host can check the case againstTaskView.CaseID(see b). - b. Return the inputs and let the host match. Add
CaseIDandReadRolestoTaskView, and the host compares them with its own record of who holds each role.TaskViewis what hosts send to clients, so decide whether these fields go over the wire or are taggedjson:"-".
Either way, update
frontend-guide.mdandintegration-guide.mdso no step tells a host to readtaskflow_task_roles. - a. Match roles in
This is a breaking change if (a) changes GetTaskRenderInfo's signature; a new method alongside it avoids that.
Version
910de31
Additional Context
- OpenNSW/core#383 makes hosts go through
TaskManagerfor finding and listing tasks (GetTaskswith the new step filter), and documents that hosts never call the store. This closes the same gap for a single task's access check. - If both land before the next release,
TaskStoreimplementations change once for both.
- Lenguaje dominante
- Go
- Estrellas
- 6
- Forks
- 8
- Merge medio
- 21 h 36 min
- PR fusionados (30 d)
- 42
Preparar el entorno
- Sin Dockerfile ni archivo de Docker Compose
- Tiene una plantilla de pull request
- Leer la guía de contribución
Primeros pasos
- Lee el issue completo y luego la guía de contribución del proyecto.
- Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
- Haz un fork del repositorio y trabaja en una rama.
- Abre un pull request que haga referencia al número del issue.
Más de OpenNSW/core
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 74/100
Los mantenedores suelen responder en 1 día
-
payment: test fixtures hardcode real gateway names (govpay/lankapay) instead of generic placeholdersAbierto
Dificultad 2/5 1-3 horas Aptitud para principiantes 88/100
Los mantenedores suelen responder en 1 día
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 72/100
Los mantenedores suelen responder en 1 día
-
nsw-sl cleanup Type/Improvement
Dificultad 3/5 1-2 días Aptitud para principiantes 48/100
Los mantenedores suelen responder en 1 día
-
remote: let the host inject a logger, and log with one consistent policyPosiblemente ocupada @mushrafmim la tomó hace 5 días. AbiertoType/Improvement
Dificultad 4/5 3-5 días Aptitud para principiantes 22/100
Los mantenedores suelen responder en 1 día
Todos los issues de OpenNSW/core
Issues similares
-
agent-research-finding chore
Dificultad 2/5 1-3 horas Aptitud para principiantes 78/100
jordansmall/spindrift#7370 ·
Los mantenedores suelen responder en 1 día
-
☢️ Bug v3
Dificultad 2/5 1-3 horas Aptitud para principiantes 82/100
Los mantenedores suelen responder en 1 día
-
The repo's gates check is clean and runs need no swapsPosiblemente ocupada @turbot-agent-fleet la tomó hoy. Abiertoagent:ready
Dificultad 2/5 1-3 horas Aptitud para principiantes 64/100
turbot/tailpipe#677 · 2 comentarios ·
Los mantenedores suelen responder en 1 día
-
needs-kind needs-triage
Dificultad 2/5 1-3 horas Aptitud para principiantes 72/100
Los mantenedores suelen responder en 2 días
-
enhancement
Dificultad 2/5 1-3 horas Aptitud para principiantes 70/100
crossplane-contrib/provider-keycloak#806 ·
Los mantenedores suelen responder en 1 día