payment: test fixtures hardcode real gateway names (govpay/lankapay) instead of generic placeholders

Abierto Apto para principiantes
#122 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
2/5
Tiempo estimado
1-3 horas
Aptitud para principiantes
88/100
Tipo de issue
Refactorización
Claridad
Bien especificado
Estado de actividad
Tranquilo
Stack tecnológico
go
Área
testing

Línea de trabajo

Lee payment/service_test.go, payment/handler_test.go y payment/registry_test.go; usa los ID genéricos existentes, como gw1, como convención. Sustituye de manera coherente los ID de fixture govpay y lankapay, y luego ejecuta las pruebas del paquete de pagos. El trabajo estará terminado cuando las pruebas pasen con ID genéricos de marcador de posición y sin cambios de comportamiento.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

Problem

core/payment's own unit tests hardcode a real downstream consumer's gateway name — \"govpay\" — as the fixture gatewayID throughout payment/service_test.go (~25 occurrences) and payment/handler_test.go (4 occurrences), and \"lankapay\" in a couple of places in payment/registry_test.go. Predates #118 (confirmed via git show against a commit before that PR's branch point), though #118 added a few more occurrences following the existing convention.

core/payment is a generic, gateway-agnostic SDK — its own README describes it as "designed to be imported and integrated into other repositories," with GovPay+/LankaPay named only as examples of gateways a consumer might wire up, not anything baked into the framework itself. Hardcoding a specific real downstream integration's name into the framework's own generic unit tests:

  • Couples tests that are actually exercising generic PaymentGateway/PaymentService/HTTPHandler mechanics to an integration that doesn't even live in this repo (GovPay+ lives in nsw-srilanka).
  • Reads as if there's GovPay+-specific behavior being tested here, when there isn't — the tests would behave identically with any gateway ID.
  • Is already inconsistent within the package: registry_test.go uses clearly-generic placeholder IDs (gw1, method1, method2) in most of its tests, but real names (lankapay) in a couple of others.

Proposed Solution

Standardize on the generic-placeholder convention registry_test.go already partially establishes (e.g. gw1) across service_test.go and handler_test.go, replacing the govpay/lankapay fixture IDs. Mechanical rename, no behavior change — tests pass identically regardless of the string used as the gateway ID.

Scope note

Deliberately not bundled into #118 (which is otherwise unrelated in scope) — flagged there during review and split out as its own follow-up per that PR's discussion.

Lenguaje dominante
Go
Estrellas
6
Forks
8
Merge medio
21 h 36 min
PR fusionados (30 d)
42

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de OpenNSW/core

Todos los issues de OpenNSW/core

Issues similares

Más issues de Go

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.