[taskflow] Give hosts a task's read roles so they can check access to its detail
I maintainer di solito rispondono entro 1 giorno
@mushrafmim ci sta già lavorando.
Dal 3/11/2026.
Valutazione
Questa issue non è ancora stata valutata.
Descrizione
Current Limitation
Taskflow never decides who may read a task, so a host checks access itself. A listing goes through TaskManager.GetTasks with TaskFilter.Roles, which matches the caller's roles against the task's read roles in SQL. A single task's detail, TaskManager.GetTaskRenderInfo(ctx, taskID), checks nothing. frontend-guide.md says the host must first check "that the caller holds one of the task's read roles (TaskRecord.ReadRoles, stored in taskflow_task_roles) in the task's case", because a caller can request any task ID directly.
No TaskManager method lets a host do that check:
TaskView, whichGetTaskRenderInforeturns, has neither the task'sCaseIDnor its read roles.- In the store,
GetTaskandGetTaskByWorkflowIDfill everyTaskRecordfield exceptReadRoles. The roles live intaskflow_task_roles, and theTaskRecorddoc says "the read methods leave this field empty: a host that needs a task's roles reads them where InitTask stored them".
So the only way to do the required check is to query taskflow_task_roles directly. That ties every task-detail endpoint to the table, its columns and its name, outside the TaskManager API that hosts otherwise use. Hosts call TaskManager, not the store, which is the persistence port only the manager calls. A change to the table changes the host without a compile error, and a host that forgets the check exposes every task to anyone who can guess an ID.
Suggested Improvement
-
Store:
GetTaskandGetTaskByWorkflowIDreturnReadRoles, loaded fromtaskflow_task_rolesbytask_id(the leading column of its primary key).GetTaskskeeps leaving it empty, likeData: its role filter already runs in SQL, and a listing doesn't need the roles. -
Hosts: expose the check through
TaskManager, in one of two ways:- a. Match roles in
GetTaskRenderInfo(preferred). The host passes the roles the caller holds, as it does forGetTasks, and taskflow matches them by name, the same rule asTaskFilter.Matches. For example:
It returnsGetTaskRenderInfo(ctx context.Context, taskID string, roles []string) (TaskView, error)ErrTaskNotFound(or a dedicated error) when the caller holds none of the task's read roles. Taskflow still never decides who holds a role. A listing and a detail read then apply the same rule in one place, and the check can't be skipped by forgetting it. As withTaskFilter.Roles, a role the caller holds in only some cases must be passed only for a task in one of those cases; the host can check the case againstTaskView.CaseID(see b). - b. Return the inputs and let the host match. Add
CaseIDandReadRolestoTaskView, and the host compares them with its own record of who holds each role.TaskViewis what hosts send to clients, so decide whether these fields go over the wire or are taggedjson:"-".
Either way, update
frontend-guide.mdandintegration-guide.mdso no step tells a host to readtaskflow_task_roles. - a. Match roles in
This is a breaking change if (a) changes GetTaskRenderInfo's signature; a new method alongside it avoids that.
Version
910de31
Additional Context
- OpenNSW/core#383 makes hosts go through
TaskManagerfor finding and listing tasks (GetTaskswith the new step filter), and documents that hosts never call the store. This closes the same gap for a single task's access check. - If both land before the next release,
TaskStoreimplementations change once for both.
- Lingua principale
- Go
- Stelle
- 6
- Fork
- 8
- Merge medio
- 21h 36m
- PR unite (30g)
- 42
Preparare l'ambiente
- Nessun Dockerfile né file Docker Compose
- Ha un modello di pull request
- Leggi la guida per i contributori
Come iniziare
- Leggi tutta la issue e poi la guida ai contributi del progetto.
- Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
- Fai un fork del repository e lavora su un branch.
- Apri una pull request che faccia riferimento al numero della issue.
Altre issue di OpenNSW/core
-
Difficoltà 2/5 1-3 ore Idoneità per principianti 74/100
I maintainer di solito rispondono entro 1 giorno
-
payment: test fixtures hardcode real gateway names (govpay/lankapay) instead of generic placeholdersAperta
Difficoltà 2/5 1-3 ore Idoneità per principianti 88/100
I maintainer di solito rispondono entro 1 giorno
-
Difficoltà 2/5 1-3 ore Idoneità per principianti 72/100
I maintainer di solito rispondono entro 1 giorno
-
nsw-sl cleanup Type/Improvement
Difficoltà 3/5 1-2 giorni Idoneità per principianti 48/100
I maintainer di solito rispondono entro 1 giorno
-
remote: let the host inject a logger, and log with one consistent policyForse già presa @mushrafmim l’ha presa 5 giorni fa. ApertaType/Improvement
Difficoltà 4/5 3-5 giorni Idoneità per principianti 22/100
I maintainer di solito rispondono entro 1 giorno
Tutte le issue di OpenNSW/core
Issue simili
-
agent-research-finding chore
Difficoltà 2/5 1-3 ore Idoneità per principianti 78/100
jordansmall/spindrift#7370 ·
I maintainer di solito rispondono entro 1 giorno
-
☢️ Bug v3
Difficoltà 2/5 1-3 ore Idoneità per principianti 82/100
I maintainer di solito rispondono entro 1 giorno
-
The repo's gates check is clean and runs need no swapsForse già presa @turbot-agent-fleet l’ha presa oggi. Apertaagent:ready
Difficoltà 2/5 1-3 ore Idoneità per principianti 64/100
turbot/tailpipe#677 · 2 commenti ·
I maintainer di solito rispondono entro 1 giorno
-
needs-kind needs-triage
Difficoltà 2/5 1-3 ore Idoneità per principianti 72/100
I maintainer di solito rispondono entro 2 giorni
-
enhancement
Difficoltà 2/5 1-3 ore Idoneità per principianti 70/100
crossplane-contrib/provider-keycloak#806 ·
I maintainer di solito rispondono entro 1 giorno