[taskflow] Give hosts a task's read roles so they can check access to its detail

Đang mở
#384 0 bình luận 0 reaction 1 người được giao Xem trên GitHub

Maintainer thường phản hồi trong vòng 1 ngày

@mushrafmim đang làm issue này rồi.

Từ ngày 3/11/2026.

Đánh giá

Issue này chưa được đánh giá.

Mô tả

Type/Improvement
Current Limitation

Taskflow never decides who may read a task, so a host checks access itself. A listing goes through TaskManager.GetTasks with TaskFilter.Roles, which matches the caller's roles against the task's read roles in SQL. A single task's detail, TaskManager.GetTaskRenderInfo(ctx, taskID), checks nothing. frontend-guide.md says the host must first check "that the caller holds one of the task's read roles (TaskRecord.ReadRoles, stored in taskflow_task_roles) in the task's case", because a caller can request any task ID directly.

No TaskManager method lets a host do that check:

  • TaskView, which GetTaskRenderInfo returns, has neither the task's CaseID nor its read roles.
  • In the store, GetTask and GetTaskByWorkflowID fill every TaskRecord field except ReadRoles. The roles live in taskflow_task_roles, and the TaskRecord doc says "the read methods leave this field empty: a host that needs a task's roles reads them where InitTask stored them".

So the only way to do the required check is to query taskflow_task_roles directly. That ties every task-detail endpoint to the table, its columns and its name, outside the TaskManager API that hosts otherwise use. Hosts call TaskManager, not the store, which is the persistence port only the manager calls. A change to the table changes the host without a compile error, and a host that forgets the check exposes every task to anyone who can guess an ID.

Suggested Improvement
  1. Store: GetTask and GetTaskByWorkflowID return ReadRoles, loaded from taskflow_task_roles by task_id (the leading column of its primary key). GetTasks keeps leaving it empty, like Data: its role filter already runs in SQL, and a listing doesn't need the roles.

  2. Hosts: expose the check through TaskManager, in one of two ways:

    • a. Match roles in GetTaskRenderInfo (preferred). The host passes the roles the caller holds, as it does for GetTasks, and taskflow matches them by name, the same rule as TaskFilter.Matches. For example:
      GetTaskRenderInfo(ctx context.Context, taskID string, roles []string) (TaskView, error)
      
      It returns ErrTaskNotFound (or a dedicated error) when the caller holds none of the task's read roles. Taskflow still never decides who holds a role. A listing and a detail read then apply the same rule in one place, and the check can't be skipped by forgetting it. As with TaskFilter.Roles, a role the caller holds in only some cases must be passed only for a task in one of those cases; the host can check the case against TaskView.CaseID (see b).
    • b. Return the inputs and let the host match. Add CaseID and ReadRoles to TaskView, and the host compares them with its own record of who holds each role. TaskView is what hosts send to clients, so decide whether these fields go over the wire or are tagged json:"-".

    Either way, update frontend-guide.md and integration-guide.md so no step tells a host to read taskflow_task_roles.

This is a breaking change if (a) changes GetTaskRenderInfo's signature; a new method alongside it avoids that.

Version

910de31

Additional Context
  • OpenNSW/core#383 makes hosts go through TaskManager for finding and listing tasks (GetTasks with the new step filter), and documents that hosts never call the store. This closes the same gap for a single task's access check.
  • If both land before the next release, TaskStore implementations change once for both.
Ngôn ngữ chính
Go
Star
6
Fork
8
Merge trung bình
21 giờ 36 phút
Pull request đã merge (30 ngày)
42

Chuẩn bị môi trường

Bắt đầu từ đâu

  1. Đọc hết issue, rồi đọc hướng dẫn đóng góp của dự án.
  2. Bình luận trên issue rằng bạn sẽ nhận — tránh hai người làm cùng một việc.
  3. Fork repository và làm thay đổi trên một nhánh.
  4. Mở pull request có tham chiếu số hiệu của issue.

Issue khác của OpenNSW/core

Tất cả issue của OpenNSW/core

Issue tương tự

Thêm issue về Go

Nhận issue mới trong hộp thư của bạn

Bản tóm tắt ngắn những issue GitHub phù hợp với người mới.