Remove the Lambda code and placeholder functions that serve nothing (keep the Glue ETL trigger)

Abierto
  • ¿Algo no está bien?
#1,103 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
4/5
Tiempo estimado
3-5 días
Aptitud para principiantes
65/100
Tipo de issue
Refactorización
Claridad
Bien especificado
Estado de actividad
Activo
Stack tecnológico
aws, github-actions, python
Área
devops, documentation, infrastructure, testing

Línea de trabajo

Start by inventorying backend/lambda/, modules/lambda/split_url_router, the two named placeholder stack functions, and their related CI, configuration, locks, tests, and documentation. Review the infrastructure synth diff before deployment, then update infrastructure/tests/test_lambda_functions_doc.py for the sole remaining ETLTriggerLambda. Done means all listed obsolete code and resources are removed, the Glue ETL trigger remains, documentation is updated, and tests reflect the final inventory.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

enhancement post-launch

Decision (2026-10-08): remove the Lambda code and functions that serve nothing. Everything they were written for is already done elsewhere:

Lambda Was for Done today by
backend/lambda/feature_flag_evaluation fast flag answers near the user the API's evaluate endpoint, and SDK local evaluation from GET /api/v1/sdk/ruleset
backend/lambda/event_processor stream events through Kinesis the API writes events to Postgres; analysis reads them there
modules/lambda/split_url_router redirects at the CDN edge (Lambda@Edge) redirects through the API or the client SDK; no stack creates the CloudFront distribution it needs
DatabaseAccessLambda (compute stack) placeholder nothing: returns 200
AnalyticsLambda (analytics stack, Kinesis mapping) placeholder nothing: returns 200

Keep: ETLTriggerLambda (Glue ETL stack): it starts the warehouse module's Glue jobs from a daily EventBridge rule, and Lambda is the right tool for a once-a-day job.

Work (post-launch):

  • Remove backend/lambda/ and modules/lambda/split_url_router with their tests, CI jobs, import-linter config, requirements locks and docs (docs/api/split-url.md's Lambda@Edge section, docs/integrations/aws.md, the docs inventory).
  • Remove DatabaseAccessLambda and AnalyticsLambda (with their roles, log groups and the Kinesis event-source mapping) from the stacks, with the same care as #605: a synth diff reviewed first, then the deploy.
  • Update infrastructure/tests/test_lambda_functions_doc.py to the one remaining function.

If a customer later needs edge redirects or stream processing at scale, it is built fresh against the API of that day.

Lenguaje dominante
Python
Estrellas
0
Forks
4
Merge medio
6 h 5 min
PR fusionados (30 d)
453

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de Controlvar/controlvar

Todos los issues de Controlvar/controlvar

Issues similares

Más issues de Python

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.