Showcase tool: the synthetic writer does not hold a cue for its headline's reading time, so the render refuses it

Abierto Apto para principiantes
  • ¿Algo no está bien?
#1,447 2 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
2/5
Tiempo estimado
1-3 horas
Aptitud para principiantes
90/100
Tipo de issue
Error
Claridad
Bien especificado
Estado de actividad
Activo
Stack tecnológico
python
Área
testing, tooling

Línea de trabajo

Comienza con write_voiced en tests/acceptance/showcase/render/synthetic.py, especialmente con el cálculo de la duración del cue alrededor de las líneas 348-349. Compara su comportamiento con storyboard.min_cue_ms(cue) y con la duración mínima del cue de la captura real. Actualiza la duración del cue sintético y añade una prueba de aceptación con un board cuyo titular requiere una retención más larga; la captura sintética debería pasar entonces la puerta de captura.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

The showcase tool's synthetic writer (tests/acceptance/showcase/render/synthetic.py, write_voiced) is meant to produce a narrated capture "that passes every gate" (its docstring, line 326). For some storyboards it produces one that the render refuses.

What happens

write_voiced sizes each caption cue as the sum of its sentences' slots (line 348), plus an extra on every third cue (line 349). It never holds a cue for its headline's minimum reading time.

The real capture does hold a cue for storyboard.min_cue_ms(cue): the headline's reading time plus a margin. So when a cue's headline needs longer to read than its sentences take to say, the render's capture gate refuses the synthetic capture.

Measured on video 9's board, 09-design-in-depth:

cue 1: 54 characters and 10 words in 2.067 s, needs 3.834 s

The cue is "Choose New Experiment." under a 54-character headline. Video 1's board has no such cue, which is why it renders.

Expected

write_voiced holds every cue for at least min_cue_ms, as the capture does. For example, after line 349:

length = max(length, contract.frames_for_ms(storyboard.min_cue_ms(headline)))

Evidence

  • With that one line applied, video 1's synthetic capture is byte-identical to its capture without it.
  • On video 9's board, only cue 1 grows, by 56 frames, and every later cue shifts by the same amount.
  • Integrated loudness moves by 0.01 LU, because the added silence falls below the loudness gate.

A test should load a board with such a cue and assert that the synthetic capture passes the capture gate.

Lenguaje dominante
Python
Estrellas
0
Forks
4
Merge medio
5 h 19 min
PR fusionados (30 d)
503

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de Controlvar/controlvar

Todos los issues de Controlvar/controlvar

Issues similares

Más issues de Python

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.