Remove the Lambda code and placeholder functions that serve nothing (keep the Glue ETL trigger)

Aperta
  • Qualcosa non va?
#1,103 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
4/5
Tempo stimato
3-5 giorni
Idoneità per principianti
65/100
Tipo di issue
Refactoring
Chiarezza
Specificata chiaramente
Stato di attività
Attiva
Stack tecnologico
aws, github-actions, python
Ambito
devops, documentation, infrastructure, testing

Direzione di ricerca

Start by inventorying backend/lambda/, modules/lambda/split_url_router, the two named placeholder stack functions, and their related CI, configuration, locks, tests, and documentation. Review the infrastructure synth diff before deployment, then update infrastructure/tests/test_lambda_functions_doc.py for the sole remaining ETLTriggerLambda. Done means all listed obsolete code and resources are removed, the Glue ETL trigger remains, documentation is updated, and tests reflect the final inventory.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

enhancement post-launch

Decision (2026-10-08): remove the Lambda code and functions that serve nothing. Everything they were written for is already done elsewhere:

Lambda Was for Done today by
backend/lambda/feature_flag_evaluation fast flag answers near the user the API's evaluate endpoint, and SDK local evaluation from GET /api/v1/sdk/ruleset
backend/lambda/event_processor stream events through Kinesis the API writes events to Postgres; analysis reads them there
modules/lambda/split_url_router redirects at the CDN edge (Lambda@Edge) redirects through the API or the client SDK; no stack creates the CloudFront distribution it needs
DatabaseAccessLambda (compute stack) placeholder nothing: returns 200
AnalyticsLambda (analytics stack, Kinesis mapping) placeholder nothing: returns 200

Keep: ETLTriggerLambda (Glue ETL stack): it starts the warehouse module's Glue jobs from a daily EventBridge rule, and Lambda is the right tool for a once-a-day job.

Work (post-launch):

  • Remove backend/lambda/ and modules/lambda/split_url_router with their tests, CI jobs, import-linter config, requirements locks and docs (docs/api/split-url.md's Lambda@Edge section, docs/integrations/aws.md, the docs inventory).
  • Remove DatabaseAccessLambda and AnalyticsLambda (with their roles, log groups and the Kinesis event-source mapping) from the stacks, with the same care as #605: a synth diff reviewed first, then the deploy.
  • Update infrastructure/tests/test_lambda_functions_doc.py to the one remaining function.

If a customer later needs edge redirects or stream processing at scale, it is built fresh against the API of that day.

Lingua principale
Python
Stelle
0
Fork
4
Merge medio
5h 19m
PR unite (30g)
503

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di Controlvar/controlvar

Tutte le issue di Controlvar/controlvar

Issue simili

Altre issue su Python

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.