Remove the Lambda code and placeholder functions that serve nothing (keep the Glue ETL trigger)

オープン
#1,103 コメント 0 件 リアクション 0 件 担当者 0 名 GitHub で見る

メンテナーはふだん 1 日以内に返信

まだ誰も着手していません。

評価

難易度
4/5
見積もり時間
3〜5日
初心者へのやさしさ
65/100
issue の種類
リファクタリング
明瞭さ
明確に書かれている
活発さ
活発
技術スタック
aws, github-actions, python

調査の方向性

Start by inventorying backend/lambda/, modules/lambda/split_url_router, the two named placeholder stack functions, and their related CI, configuration, locks, tests, and documentation. Review the infrastructure synth diff before deployment, then update infrastructure/tests/test_lambda_functions_doc.py for the sole remaining ETLTriggerLambda. Done means all listed obsolete code and resources are removed, the Glue ETL trigger remains, documentation is updated, and tests reflect the final inventory.

索引モデルが issue の本文から書いたものです。

説明

enhancement post-launch

Decision (2026-10-08): remove the Lambda code and functions that serve nothing. Everything they were written for is already done elsewhere:

Lambda Was for Done today by
backend/lambda/feature_flag_evaluation fast flag answers near the user the API's evaluate endpoint, and SDK local evaluation from GET /api/v1/sdk/ruleset
backend/lambda/event_processor stream events through Kinesis the API writes events to Postgres; analysis reads them there
modules/lambda/split_url_router redirects at the CDN edge (Lambda@Edge) redirects through the API or the client SDK; no stack creates the CloudFront distribution it needs
DatabaseAccessLambda (compute stack) placeholder nothing: returns 200
AnalyticsLambda (analytics stack, Kinesis mapping) placeholder nothing: returns 200

Keep: ETLTriggerLambda (Glue ETL stack): it starts the warehouse module's Glue jobs from a daily EventBridge rule, and Lambda is the right tool for a once-a-day job.

Work (post-launch):

  • Remove backend/lambda/ and modules/lambda/split_url_router with their tests, CI jobs, import-linter config, requirements locks and docs (docs/api/split-url.md's Lambda@Edge section, docs/integrations/aws.md, the docs inventory).
  • Remove DatabaseAccessLambda and AnalyticsLambda (with their roles, log groups and the Kinesis event-source mapping) from the stacks, with the same care as #605: a synth diff reviewed first, then the deploy.
  • Update infrastructure/tests/test_lambda_functions_doc.py to the one remaining function.

If a customer later needs edge redirects or stream processing at scale, it is built fresh against the API of that day.

主要言語
Python
スター
0
フォーク
4
平均マージ
5時間 19分
マージ済み PR(30日)
503

環境構築

はじめの一歩

  1. issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
  2. 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
  3. リポジトリをフォークし、ブランチを切って変更します。
  4. issue 番号を参照したプルリクエストを送ります。

Controlvar/controlvar のほかの issue

Controlvar/controlvar の issue をすべて見る

似ている issue

Python の issue をもっと見る

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。