Hacktoberfest 2026: los issues que los mantenedores marcaron para octubre, abiertos y aptos para principiantes. Explorar issues de Hacktoberfest

IdentifyBuiltinColorSpace heuristics failure edgecases: ACEScc, ADX16, CIE-XYZ-D65

Abierto
  • ¿Algo no está bien?
#2,222 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
5/5
Tiempo estimado
Más de una semana
Aptitud para principiantes
35/100
Tipo de issue
Error
Claridad
Bastante claro
Estado de actividad
Estancado
Stack tecnológico
cpp, python
Área
computer-graphics

Línea de trabajo

Comienza ejecutando la reproducción de Python proporcionada contra ocio://studio-config-latest y compara los resultados de IdentifyBuiltinColorSpace entre las distintas flags de optimización y configuraciones de espacios de color inactivos. Después, inspecciona Config::IdentifyBuiltinColorSpace y las rutas de matching de ACEScc, ADX16 y CIE XYZ-D65 BuiltinTransform. La tarea está terminada cuando los espacios de color equivalentes enumerados se identifiquen de forma coherente y se cubra el comportamiento solicitado de visibilidad y optimización.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

Feature Request

Apparently, ACEScc, ADX16, and both CIE XYZ-D65 spaces from ocio://studio-config-latest (as of OCIO v2.5.0) are evading our out-of-the-box matching / identification algorithms.

I've been noticing that, very occasionally, Config::IdentifyBuiltinColorSpace has trouble matching certain color spaces among configs that really do share functionally identical definitions, and should, by all accounts, be recognized as equivalent.

I wrote a little function to assess which color spaces in a given config IdentifyBuiltinColorSpace seems to have the most trouble with -- essentially, I'm using the exact same config for both the srcConfig and the builtinConfig, and just collecting the color spaces that can't be found in their own configs.

In exploring this, I found that both optimization flags (unsurprisingly) and color space visibility (surprisingly) affect the rate of success.

Insights:

  • It would be useful if there were a way to force Config.IdentifyBuiltinColorSpace to always attempt to failover to searching inactive color spaces.
  • It would be nice if IdentifyBuiltinColorSpace exposed an optional optimizationFlags argument as a means of fine-tuning the equivalency "tolerance"

Findings:

  • "ADX16" color spaces based off of the ADX16_to_ACES2065-1 BuiltinTransform can be matched when using DRAFT optimization or higher
  • "ACEScc" and "ACESproxy10i" color spaces based off of the ACEScc_to_ACES2065-1 ACESproxy10i_to_ACES2065-1 BuiltinTransform styles respectively remain "unmatchable", regardless of optimization settings.

Here's a python snippet if you wanna mess around:

import PyOpenColorIO as ocio
import os

def get_unmatchable_color_spaces(
    config: ocio.Config, 
    optimization: ocio.OptimizationFlags | int | None = None,
    exclude_inactive: bool = False, 
    verbose: bool = False,
) -> list[str]:
    
    # Optimization Flags affect the identification heuristics. The API doesn't expose a way
    # to directly control the optimization flags used for identifying color spaces, but we
    # can temporarily adjust the $OCIO_OPTIMIZATION_FLAGS environment variable
    # if we want to temporarily override the global optimization behavior

    # Preserve the previous environment to restore later.
    prev_env = dict(os.environ)
    if optimization:
        # Temporarily set $OCIO_OPTIMIZATION_FLAGS to the requested value.
        os.environ[ocio.OCIO_OPTIMIZATION_FLAGS_ENVVAR] = str(int(optimization))

    
    # Color space visiblity affects the identification heuristics.
    # To maximize the likelihood of finding a match, we can temporarily
    # activate all color spaces. 

    # Store the old inactive color spaces to restore later.
    old_invisible_color_spaces = config.getInactiveColorSpaces()
    
    if not exclude_inactive:
        # Temporarily make all color spaces visible.
        config.setInactiveColorSpaces("")

    
    # Iterate over all the color spaces in the config, and collect names of 
    # color spaces that steadfastly refuse to be matched!
    problem_spaces = []
    for cs_name in config.getColorSpaceNames(
        ocio.SEARCH_REFERENCE_SPACE_ALL, 
        ocio.COLORSPACE_ALL
    ):
        # Try to match each color space in the config to... itself!
        try:
            matched_space = ocio.Config.IdentifyBuiltinColorSpace(config, config, cs_name)
        except ocio.Exception as e:
            if verbose:
                ocio.LogMessage(ocio.LOGGING_LEVEL_WARNING, str(e))
            problem_spaces.append(cs_name)

    # Cleanup -- restore the previous environment and config state.`
    os.environ.clear()
    os.environ.update(prev_env)
    config.setInactiveColorSpaces(old_invisible_color_spaces)
    
    return sorted(problem_spaces)

studio_config_modified = ocio.Config.CreateFromFile("ocio://studio-config-latest")

# Add an ACESproxy10i color space to the studio-config, because I suspect it'll also fail to match itself.
studio_config_modified.addColorSpace(
    ocio.ColorSpace(
        ocio.REFERENCE_SPACE_SCENE,
        name="ACESproxy10i",
        toReference= ocio.BuiltinTransform("ACESproxy10i_to_ACES2065-1")
    )
)

print(f"""
Unmatchable color spaces: {studio_config_modified.getName()}
---

 - Default IdentifyBuiltinColorSpace behavior: 
   {get_unmatchable_color_spaces(studio_config_modified, exclude_inactive=True)}
 
 - Ignore visibility + no optimizations: 
   {get_unmatchable_color_spaces(studio_config_modified, optimization=ocio.OPTIMIZATION_NONE)}
 
-  Ignore visibility + draft optimizations: 
   {get_unmatchable_color_spaces(studio_config_modified, optimization=ocio.OPTIMIZATION_DRAFT)}
""")


Unmatchable color spaces: studio-config-v4.0.0_aces-v2.0_ocio-v2.5
---

 - Default IdentifyBuiltinColorSpace behavior: 
   ['ACEScc', 'ACESproxy10i', 'ADX16', 'CIE XYZ-D65 - Display-referred', 'CIE XYZ-D65 - Scene-referred']
 
 - Ignore visibility + no optimizations: 
   ['ACEScc', 'ACESproxy10i', 'ADX16']
 
-  Ignore visibility + draft optimizations: 
   ['ACEScc', 'ACESproxy10i']
Lenguaje dominante
C++
Estrellas
2.1k
Forks
502
Merge medio
6 d 3 h
PR fusionados (30 d)
6

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de AcademySoftwareFoundation/OpenColorIO

Todos los issues de AcademySoftwareFoundation/OpenColorIO

Issues similares

Más issues de C++

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.