[Bug]: Edit Bar buttons are not localized
Maintainers usually reply within 1 day
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 70/100
- Issue type
- Bug
- Clarity
- Clearly specified
- Activity status
- Active
- Tech stack
- csharp
- Domain
- localization
Research direction
Start in DesktopModules/Admin/Dnn.EditBar, where the four button labels and tooltips are rendered, and compare them with the keys in App_LocalResources/*.resx. Check whether the markup or code-behind reads these strings through the localization lookup, and why the installed tr-TR resx is not used. Done when the buttons and tooltips show the translations on /tr-tr/ as a host, with the English defaults unchanged.
Written by the indexing model from the issue text.
Description
Is there an existing issue for this?
- I have searched the existing issues
What happened?
When a host or admin opens a page in a non-English culture (for example /tr-tr/), the edit bar at the bottom of the page shows Add Module, Add Existing Module, Page Settings and Close in English. This happens even when a language pack with translations for these strings is installed. Their hover tooltips also stay in English.
Steps to reproduce?
Steps to reproduce
- Install a language pack (for example tr-TR) that includes DesktopModules/Admin/Dnn.EditBar/App_LocalResources/*.tr-TR.resx.
- Enable the language and go to a page in that culture, for example https://site/tr-tr/.
- Log in as host and look at the edit bar at the bottom of the page.
Current Behavior
All four buttons and their tooltips are in English.
Expected Behavior
The buttons and tooltips use the installed translations, for example "Modül Ekle", "Mevcut Modülü Ekle", "Sayfa Ayarları" and "Kapat".
Relevant log output
Anything else?
I'm going to submit a PR to fix this issue.
Affected Versions
10.4.0 (latest release)
What browsers are you seeing the problem on?
No response
Code of Conduct
- I agree to follow this project's Code of Conduct
- Dominant language
- C#
- Stars
- 1.1k
- Forks
- 791
- Avg merge
- 2d 2h
- Merged PRs (30d)
- 24
Getting set up
- No Dockerfile or Docker Compose file
- Has a pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from dnnsoftware/Dnn.Platform
-
Status: New
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
dnnsoftware/Dnn.Platform#7543 · 3 comments ·
Maintainers usually reply within 1 day
-
Status: New
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
dnnsoftware/Dnn.Platform#6681 ·
Maintainers usually reply within 1 day
-
Status: New
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
dnnsoftware/Dnn.Platform#6051 · 4 comments ·
Maintainers usually reply within 1 day
-
Status: New
Difficulty 3/5 1-2 days Newbie friendliness 45/100
dnnsoftware/Dnn.Platform#7555 ·
Maintainers usually reply within 1 day
-
Status: New
Difficulty 3/5 1-2 days Newbie friendliness 62/100
dnnsoftware/Dnn.Platform#7550 ·
Maintainers usually reply within 1 day
All issues in dnnsoftware/Dnn.Platform
Similar issues
-
ASP.NET Core container quickstart: `docker-run: debug` task sample is missing its closing braceOpen
Difficulty 1/5 Under an hour Newbie friendliness 88/100
microsoft/vscode-docs#10499 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
Maintainers usually reply within 1 day
-
python triage
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
microsoft/semantic-kernel#14615 ·
Maintainers usually reply within 3 days
-
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
vzeol/DeployCraft#125 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
apache/arrow-adbc#4915 · 1 comment ·
Maintainers usually reply within 1 day