Migrate git hook & staged linting runners

Offen
  • Stimmt etwas nicht?
#3,274 1 Kommentar 0 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen

Maintainer antworten meist innerhalb von 1 Tag

Dieses Issue hat noch niemand übernommen.

Bewertung

Schwierigkeit
4/5
Geschätzter Aufwand
3-5 Tage
Anfängerfreundlichkeit
48/100
Issue-Typ
Feature
Klarheit
Größtenteils klar
Aktivitätsstatus
Aktiv
Tech-Stack
git, rust
Bereich
cli, developer-experience

Rechercherichtung

Start by reading the vp migrate implementation and its existing lint-staged migration, then inspect how it detects and reads project configuration. The issue names nano-staged, husky, simple-git-hooks, lefthook, and pre-commit/prek as candidates. Done means supported configurations migrate appropriately, with a warning considered for pre-commit/prek; the exact support scope still needs discussion.

Vom Indexierungsmodell aus dem Issue-Text verfasst.

Beschreibung

pending triage triage: not actionable
Description

Currently, Vite+ only supports migrating lint-staged (I think?). This means that users of the following tools are not migrated:

  • nano-staged
  • husky
  • simple-git-hooks
  • lefthook
  • pre-commit/prek(?)
  • etc etc
Suggested solution

vp migrate should be able to read the configurations of those tools above and migrate them to Vite+, as appropriate.

Alternative

Users could migrate themselves, this is just a convenience factor like other migrations.

Additional context

I'm not sure if migrating pre-commit/prek is necessarily a good or at least feasible idea. Maybe just warn when pre-commit-config.yaml is detected instead?
The thing is that pre-commit (and prek, but I'll refer to it and pre-commit together) have a whole different system for doing its thing, which may be out-of-scope for Vite+. Seeking feedback, as it'd be really awesome if Vite+ could have support for the pre-commit framework, but understandable if that's considered out-of-scope. (There are various tools that use pre-commit framework, one of the biggest examples being the zizmor analyzer)

I can create a separate issue for this if needed.

Validations
  • Read the Contributing Guidelines.
  • Confirm this request is for Vite+ itself and not for Vite, Vitest, tsdown, Rolldown, or Oxc.
  • Check that there isn't already an issue requesting the same feature.
Vorherrschende Sprache
Rust
Sterne
6.5k
Forks
297
Ø Merge
20 Std. 56 Min.
Gemergte PRs (30 T.)
234

Entwicklungsumgebung

In Codespaces öffnen

Startet den Dev-Container des Projekts im Browser, mit Ihrem eigenen GitHub-Konto.

Erste Schritte

  1. Lesen Sie das ganze Issue und danach den Beitragsleitfaden des Projekts.
  2. Schreiben Sie ins Issue, dass Sie es übernehmen — das erspart doppelte Arbeit.
  3. Forken Sie das Repository und arbeiten Sie in einem Branch.
  4. Öffnen Sie einen Pull Request, der die Issue-Nummer nennt.

Mehr aus voidzero-dev/vite-plus

Alle Issues in voidzero-dev/vite-plus

Ähnliche Issues

Weitere Issues zu Rust

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.