Migrate git hook & staged linting runners

Ouverte
#3,274 1 commentaire 0 réactions 0 personnes assignées Voir sur GitHub

Les mainteneurs répondent en général sous 1 jour

Personne n'a encore pris cette issue.

Évaluation

Difficulté
4/5
Temps estimé
3-5 jours
Accessibilité débutants
48/100
Type d'issue
Fonctionnalité
Clarté
Plutôt claire
Activité
Active
Stack technique
git, rust

Piste de recherche

Start by reading the vp migrate implementation and its existing lint-staged migration, then inspect how it detects and reads project configuration. The issue names nano-staged, husky, simple-git-hooks, lefthook, and pre-commit/prek as candidates. Done means supported configurations migrate appropriately, with a warning considered for pre-commit/prek; the exact support scope still needs discussion.

Rédigé par le modèle d'indexation à partir du texte de l'issue.

Description

pending triage triage: not actionable
Description

Currently, Vite+ only supports migrating lint-staged (I think?). This means that users of the following tools are not migrated:

  • nano-staged
  • husky
  • simple-git-hooks
  • lefthook
  • pre-commit/prek(?)
  • etc etc
Suggested solution

vp migrate should be able to read the configurations of those tools above and migrate them to Vite+, as appropriate.

Alternative

Users could migrate themselves, this is just a convenience factor like other migrations.

Additional context

I'm not sure if migrating pre-commit/prek is necessarily a good or at least feasible idea. Maybe just warn when pre-commit-config.yaml is detected instead?
The thing is that pre-commit (and prek, but I'll refer to it and pre-commit together) have a whole different system for doing its thing, which may be out-of-scope for Vite+. Seeking feedback, as it'd be really awesome if Vite+ could have support for the pre-commit framework, but understandable if that's considered out-of-scope. (There are various tools that use pre-commit framework, one of the biggest examples being the zizmor analyzer)

I can create a separate issue for this if needed.

Validations
  • Read the Contributing Guidelines.
  • Confirm this request is for Vite+ itself and not for Vite, Vitest, tsdown, Rolldown, or Oxc.
  • Check that there isn't already an issue requesting the same feature.
Langage dominant
Rust
Étoiles
6.5k
Forks
297
Merge moyen
20 h 18 min
PR mergées (30 j)
236

Préparer son environnement

Ouvrir dans Codespaces

Lance le conteneur de développement du projet dans votre navigateur, avec votre propre compte GitHub.

Par où commencer

  1. Lisez l'issue en entier, puis le guide de contribution du projet.
  2. Signalez en commentaire que vous la prenez — cela évite que deux personnes fassent le même travail.
  3. Forkez le dépôt et travaillez sur une branche.
  4. Ouvrez une pull request qui référence le numéro de l'issue.

Autres issues de voidzero-dev/vite-plus

Toutes les issues de voidzero-dev/vite-plus

Issues similaires

Plus d'issues Rust

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.