Migrate git hook & staged linting runners

オープン
#3,274 コメント 1 件 リアクション 0 件 担当者 0 名 GitHub で見る

メンテナーはふだん 1 日以内に返信

まだ誰も着手していません。

評価

難易度
4/5
見積もり時間
3〜5日
初心者へのやさしさ
48/100
issue の種類
機能追加
明瞭さ
おおむね明確
活発さ
活発
技術スタック
git, rust

調査の方向性

Start by reading the vp migrate implementation and its existing lint-staged migration, then inspect how it detects and reads project configuration. The issue names nano-staged, husky, simple-git-hooks, lefthook, and pre-commit/prek as candidates. Done means supported configurations migrate appropriately, with a warning considered for pre-commit/prek; the exact support scope still needs discussion.

索引モデルが issue の本文から書いたものです。

説明

pending triage triage: not actionable
Description

Currently, Vite+ only supports migrating lint-staged (I think?). This means that users of the following tools are not migrated:

  • nano-staged
  • husky
  • simple-git-hooks
  • lefthook
  • pre-commit/prek(?)
  • etc etc
Suggested solution

vp migrate should be able to read the configurations of those tools above and migrate them to Vite+, as appropriate.

Alternative

Users could migrate themselves, this is just a convenience factor like other migrations.

Additional context

I'm not sure if migrating pre-commit/prek is necessarily a good or at least feasible idea. Maybe just warn when pre-commit-config.yaml is detected instead?
The thing is that pre-commit (and prek, but I'll refer to it and pre-commit together) have a whole different system for doing its thing, which may be out-of-scope for Vite+. Seeking feedback, as it'd be really awesome if Vite+ could have support for the pre-commit framework, but understandable if that's considered out-of-scope. (There are various tools that use pre-commit framework, one of the biggest examples being the zizmor analyzer)

I can create a separate issue for this if needed.

Validations
  • Read the Contributing Guidelines.
  • Confirm this request is for Vite+ itself and not for Vite, Vitest, tsdown, Rolldown, or Oxc.
  • Check that there isn't already an issue requesting the same feature.
主要言語
Rust
スター
6.5k
フォーク
297
平均マージ
20時間 56分
マージ済み PR(30日)
234

環境構築

Codespaces で開く

このプロジェクトの開発コンテナを、あなたの GitHub アカウントでブラウザ上に起動します。

はじめの一歩

  1. issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
  2. 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
  3. リポジトリをフォークし、ブランチを切って変更します。
  4. issue 番号を参照したプルリクエストを送ります。

voidzero-dev/vite-plus のほかの issue

voidzero-dev/vite-plus の issue をすべて見る

似ている issue

Rust の issue をもっと見る

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。