Various specs fail on Windows for all Ruby versions

Offen
  • Stimmt etwas nicht?
#836 0 Kommentare 0 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen

Maintainer antworten meist innerhalb von 1 Tag

Dieses Issue hat noch niemand übernommen.

Bewertung

Schwierigkeit
4/5
Geschätzter Aufwand
Über eine Woche
Anfängerfreundlichkeit
22/100
Issue-Typ
Bug
Klarheit
Größtenteils klar
Aktivitätsstatus
Veraltet
Tech-Stack
git, ruby
Bereich
devtools, testing

Rechercherichtung

The failing specs are listed by file and line, across spec/integration (committing_spec.rb, resolving_cherry_pick_conflict_spec.rb), spec/overcommit/git_repo_spec.rb, several spec/overcommit/hook/pre_commit specs, and replace_branch_spec.rb. Start by running one listed spec on Windows to see the actual error, since the issue gives no cause. Done when the listed specs pass on Windows and the path-handling and git-invocation differences are understood.

Vom Indexierungsmodell aus dem Issue-Text verfasst.

Beschreibung

At the moment of writing this Issue, these are the specs that are failing:

rspec ./spec/integration/committing_spec.rb:85 # commiting to an empty repo when a hook fails exits with a non-zero status
rspec ./spec/integration/resolving_cherry_pick_conflict_spec.rb:41 # resolving cherry-pick conflicts exits with a non-zero status
rspec ./spec/integration/resolving_cherry_pick_conflict_spec.rb:46 # resolving cherry-pick conflicts does not remove the CHERRY_PICK_HEAD file
rspec ./spec/integration/resolving_cherry_pick_conflict_spec.rb:52 # resolving cherry-pick conflicts keeps the commit message from the cherry-picked commit
rspec ./spec/overcommit/git_repo_spec.rb:218 # Overcommit::GitRepo.list_files when listing contents of a directory when directory contains a file when path contains spaces is expected to include "D:/a/_temp/d20240224-2700-ihp1yw/some-repo/some dir/file"
rspec ./spec/overcommit/hook/pre_commit/hard_tabs_spec.rb:26 # Overcommit::Hook::PreCommit::HardTabs when file contains hard tabs is expected to fail
rspec ./spec/overcommit/hook/pre_commit/local_paths_in_gemfile_spec.rb:27 # Overcommit::Hook::PreCommit::LocalPathsInGemfile when file contains a local path in Ruby 1.8 hash syntax format is expected to report a warning
rspec ./spec/overcommit/hook/pre_commit/local_paths_in_gemfile_spec.rb:33 # Overcommit::Hook::PreCommit::LocalPathsInGemfile when file contains a local path on its own line in Ruby 1.8 hash syntax format is expected to report a warning
rspec ./spec/overcommit/hook/pre_commit/local_paths_in_gemfile_spec.rb:39 # Overcommit::Hook::PreCommit::LocalPathsInGemfile when file contains a local path starting with leading spaces in Ruby 1.8 hash format is expected to report a warning
rspec ./spec/overcommit/hook/pre_commit/local_paths_in_gemfile_spec.rb:45 # Overcommit::Hook::PreCommit::LocalPathsInGemfile when file contains a local path in Ruby 1.9 hash syntax format is expected to report a warning
rspec ./spec/overcommit/hook/pre_commit/local_paths_in_gemfile_spec.rb:51 # Overcommit::Hook::PreCommit::LocalPathsInGemfile when file contains local path on its own line in Ruby 1.9 hash syntax format is expected to report a warning
rspec ./spec/overcommit/hook/pre_commit/local_paths_in_gemfile_spec.rb:57 # Overcommit::Hook::PreCommit::LocalPathsInGemfile when file contains local path starting with leading spaces in Ruby 1.9 hash format is expected to report a warning
rspec ./spec/overcommit/hook/pre_commit/merge_conflicts_spec.rb:27 # Overcommit::Hook::PreCommit::MergeConflicts when file contains a merge conflict marker is expected to fail
rspec ./spec/overcommit/hook/pre_commit/trailing_whitespace_spec.rb:26 # Overcommit::Hook::PreCommit::TrailingWhitespace when file contains trailing whitespace is expected to fail
rspec ./spec/overcommit/hook/pre_commit/trailing_whitespace_spec.rb:32 # Overcommit::Hook::PreCommit::TrailingWhitespace when file contains trailing tabs is expected to fail
rspec ./spec/overcommit/hook/prepare_commit_msg/replace_branch_spec.rb:79 # Overcommit::Hook::PrepareCommitMsg::ReplaceBranch#run when the checked out branch matches the pattern when skip_if exits with a zero status does not change the commit message
Vorherrschende Sprache
Ruby
Sterne
4k
Forks
288
Ø Merge
2 T. 4 Std.
Gemergte PRs (30 T.)
18

Entwicklungsumgebung

Erste Schritte

  1. Lesen Sie das ganze Issue und danach den Beitragsleitfaden des Projekts.
  2. Schreiben Sie ins Issue, dass Sie es übernehmen — das erspart doppelte Arbeit.
  3. Forken Sie das Repository und arbeiten Sie in einem Branch.
  4. Öffnen Sie einen Pull Request, der die Issue-Nummer nennt.

Mehr aus sds/overcommit

Alle Issues in sds/overcommit

Ähnliche Issues

Weitere Issues zu Ruby

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.