Various specs fail on Windows for all Ruby versions

Aperta
  • Qualcosa non va?
#836 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
4/5
Tempo stimato
Più di una settimana
Idoneità per principianti
22/100
Tipo di issue
Bug
Chiarezza
Abbastanza chiara
Stato di attività
Ferma
Stack tecnologico
git, ruby
Ambito
devtools, testing

Direzione di ricerca

The failing specs are listed by file and line, across spec/integration (committing_spec.rb, resolving_cherry_pick_conflict_spec.rb), spec/overcommit/git_repo_spec.rb, several spec/overcommit/hook/pre_commit specs, and replace_branch_spec.rb. Start by running one listed spec on Windows to see the actual error, since the issue gives no cause. Done when the listed specs pass on Windows and the path-handling and git-invocation differences are understood.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

At the moment of writing this Issue, these are the specs that are failing:

rspec ./spec/integration/committing_spec.rb:85 # commiting to an empty repo when a hook fails exits with a non-zero status
rspec ./spec/integration/resolving_cherry_pick_conflict_spec.rb:41 # resolving cherry-pick conflicts exits with a non-zero status
rspec ./spec/integration/resolving_cherry_pick_conflict_spec.rb:46 # resolving cherry-pick conflicts does not remove the CHERRY_PICK_HEAD file
rspec ./spec/integration/resolving_cherry_pick_conflict_spec.rb:52 # resolving cherry-pick conflicts keeps the commit message from the cherry-picked commit
rspec ./spec/overcommit/git_repo_spec.rb:218 # Overcommit::GitRepo.list_files when listing contents of a directory when directory contains a file when path contains spaces is expected to include "D:/a/_temp/d20240224-2700-ihp1yw/some-repo/some dir/file"
rspec ./spec/overcommit/hook/pre_commit/hard_tabs_spec.rb:26 # Overcommit::Hook::PreCommit::HardTabs when file contains hard tabs is expected to fail
rspec ./spec/overcommit/hook/pre_commit/local_paths_in_gemfile_spec.rb:27 # Overcommit::Hook::PreCommit::LocalPathsInGemfile when file contains a local path in Ruby 1.8 hash syntax format is expected to report a warning
rspec ./spec/overcommit/hook/pre_commit/local_paths_in_gemfile_spec.rb:33 # Overcommit::Hook::PreCommit::LocalPathsInGemfile when file contains a local path on its own line in Ruby 1.8 hash syntax format is expected to report a warning
rspec ./spec/overcommit/hook/pre_commit/local_paths_in_gemfile_spec.rb:39 # Overcommit::Hook::PreCommit::LocalPathsInGemfile when file contains a local path starting with leading spaces in Ruby 1.8 hash format is expected to report a warning
rspec ./spec/overcommit/hook/pre_commit/local_paths_in_gemfile_spec.rb:45 # Overcommit::Hook::PreCommit::LocalPathsInGemfile when file contains a local path in Ruby 1.9 hash syntax format is expected to report a warning
rspec ./spec/overcommit/hook/pre_commit/local_paths_in_gemfile_spec.rb:51 # Overcommit::Hook::PreCommit::LocalPathsInGemfile when file contains local path on its own line in Ruby 1.9 hash syntax format is expected to report a warning
rspec ./spec/overcommit/hook/pre_commit/local_paths_in_gemfile_spec.rb:57 # Overcommit::Hook::PreCommit::LocalPathsInGemfile when file contains local path starting with leading spaces in Ruby 1.9 hash format is expected to report a warning
rspec ./spec/overcommit/hook/pre_commit/merge_conflicts_spec.rb:27 # Overcommit::Hook::PreCommit::MergeConflicts when file contains a merge conflict marker is expected to fail
rspec ./spec/overcommit/hook/pre_commit/trailing_whitespace_spec.rb:26 # Overcommit::Hook::PreCommit::TrailingWhitespace when file contains trailing whitespace is expected to fail
rspec ./spec/overcommit/hook/pre_commit/trailing_whitespace_spec.rb:32 # Overcommit::Hook::PreCommit::TrailingWhitespace when file contains trailing tabs is expected to fail
rspec ./spec/overcommit/hook/prepare_commit_msg/replace_branch_spec.rb:79 # Overcommit::Hook::PrepareCommitMsg::ReplaceBranch#run when the checked out branch matches the pattern when skip_if exits with a zero status does not change the commit message
Lingua principale
Ruby
Stelle
4k
Fork
288
Merge medio
2g 4h
PR unite (30g)
18

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di sds/overcommit

Tutte le issue di sds/overcommit

Issue simili

Altre issue su Ruby

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.