Various specs fail on Windows for all Ruby versions

未關閉
  • 哪裡不對？
#836 0 則留言 0 個 reaction 已指派 0 人 在 GitHub 檢視

維護者通常 1 天內回覆

還沒有人認領這個 Issue。

評估

難度
4/5
預估耗時
一週以上
新手友好度
22/100
Issue 類型
缺陷
描述清晰度
基本清楚
活躍度
停滯
技術堆疊
git, ruby
領域
devtools, testing

研究方向

The failing specs are listed by file and line, across spec/integration (committing_spec.rb, resolving_cherry_pick_conflict_spec.rb), spec/overcommit/git_repo_spec.rb, several spec/overcommit/hook/pre_commit specs, and replace_branch_spec.rb. Start by running one listed spec on Windows to see the actual error, since the issue gives no cause. Done when the listed specs pass on Windows and the path-handling and git-invocation differences are understood.

由索引模型根據 Issue 內容生成。

描述

At the moment of writing this Issue, these are the specs that are failing:

rspec ./spec/integration/committing_spec.rb:85 # commiting to an empty repo when a hook fails exits with a non-zero status
rspec ./spec/integration/resolving_cherry_pick_conflict_spec.rb:41 # resolving cherry-pick conflicts exits with a non-zero status
rspec ./spec/integration/resolving_cherry_pick_conflict_spec.rb:46 # resolving cherry-pick conflicts does not remove the CHERRY_PICK_HEAD file
rspec ./spec/integration/resolving_cherry_pick_conflict_spec.rb:52 # resolving cherry-pick conflicts keeps the commit message from the cherry-picked commit
rspec ./spec/overcommit/git_repo_spec.rb:218 # Overcommit::GitRepo.list_files when listing contents of a directory when directory contains a file when path contains spaces is expected to include "D:/a/_temp/d20240224-2700-ihp1yw/some-repo/some dir/file"
rspec ./spec/overcommit/hook/pre_commit/hard_tabs_spec.rb:26 # Overcommit::Hook::PreCommit::HardTabs when file contains hard tabs is expected to fail
rspec ./spec/overcommit/hook/pre_commit/local_paths_in_gemfile_spec.rb:27 # Overcommit::Hook::PreCommit::LocalPathsInGemfile when file contains a local path in Ruby 1.8 hash syntax format is expected to report a warning
rspec ./spec/overcommit/hook/pre_commit/local_paths_in_gemfile_spec.rb:33 # Overcommit::Hook::PreCommit::LocalPathsInGemfile when file contains a local path on its own line in Ruby 1.8 hash syntax format is expected to report a warning
rspec ./spec/overcommit/hook/pre_commit/local_paths_in_gemfile_spec.rb:39 # Overcommit::Hook::PreCommit::LocalPathsInGemfile when file contains a local path starting with leading spaces in Ruby 1.8 hash format is expected to report a warning
rspec ./spec/overcommit/hook/pre_commit/local_paths_in_gemfile_spec.rb:45 # Overcommit::Hook::PreCommit::LocalPathsInGemfile when file contains a local path in Ruby 1.9 hash syntax format is expected to report a warning
rspec ./spec/overcommit/hook/pre_commit/local_paths_in_gemfile_spec.rb:51 # Overcommit::Hook::PreCommit::LocalPathsInGemfile when file contains local path on its own line in Ruby 1.9 hash syntax format is expected to report a warning
rspec ./spec/overcommit/hook/pre_commit/local_paths_in_gemfile_spec.rb:57 # Overcommit::Hook::PreCommit::LocalPathsInGemfile when file contains local path starting with leading spaces in Ruby 1.9 hash format is expected to report a warning
rspec ./spec/overcommit/hook/pre_commit/merge_conflicts_spec.rb:27 # Overcommit::Hook::PreCommit::MergeConflicts when file contains a merge conflict marker is expected to fail
rspec ./spec/overcommit/hook/pre_commit/trailing_whitespace_spec.rb:26 # Overcommit::Hook::PreCommit::TrailingWhitespace when file contains trailing whitespace is expected to fail
rspec ./spec/overcommit/hook/pre_commit/trailing_whitespace_spec.rb:32 # Overcommit::Hook::PreCommit::TrailingWhitespace when file contains trailing tabs is expected to fail
rspec ./spec/overcommit/hook/prepare_commit_msg/replace_branch_spec.rb:79 # Overcommit::Hook::PrepareCommitMsg::ReplaceBranch#run when the checked out branch matches the pattern when skip_if exits with a zero status does not change the commit message
主要語言
Ruby
星號
4k
分支
288
平均合併
2 天 4 小時
30 天內合併 PR
18

環境準備

  • 沒有 Dockerfile 或 Docker Compose 檔案
  • 沒有 Pull Request 範本
  • 閱讀貢獻指南

從這裡開始

  1. 先讀完整個 Issue，再讀專案的貢獻指南。
  2. 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
  3. Fork 儲存庫，在一個分支上完成修改。
  4. 送出 Pull Request，並在描述裡引用這個 Issue 編號。

sds/overcommit 的其他 Issue

查看 sds/overcommit 的全部 Issue

相似的 Issue

更多 Ruby Issue

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。