NamespaceManagement cleanup can delete RBAC in unrelated namespaces

Offen
#1,557 0 Kommentare 0 Reaktionen 1 zugewiesene Person Auf GitHub ansehen

Maintainer antworten meist innerhalb von 1 Tag

@Rizwana777 arbeitet bereits daran.

Seit 16.11.2026.

Bewertung

Schwierigkeit
4/5
Geschätzter Aufwand
3-5 Tage
Anfängerfreundlichkeit
22/100
Issue-Typ
Bug
Klarheit
Größtenteils klar
Aktivitätsstatus
Aktiv
Tech-Stack
go, kubernetes
Bereich
devops, security

Rechercherichtung

Start in argocd-operator/controllers/argocd/util.go around lines 1999-2015, where cleanupRBACsForNamespaceManagement is called from handleArgoCDNamespaceManagementUpdate, then read deleteRBACsForNamespace. Confirm the Roles and RoleBindings deleted there are not filtered by owning instance. Done means deletion is limited to grants owned by the originating ArgoCD, with regression tests for unrelated namespaces both with and without the feature flag.

Vom Indexierungsmodell aus dem Issue-Text verfasst.

Beschreibung

kind/bug

A user who can create and update an ArgoCD CR in their own namespace can cause the operator to delete Argo CD Roles and RoleBindings in another namespace, without permission or consent from that namespace. This also occurs when ALLOW_NAMESPACE_MANAGEMENT_IN_NAMESPACE_SCOPED_INSTANCES=false.

Reproduction

With a cluster-wide operator installation and existing Argo CD RBAC in namespace victim:

  1. Create an ArgoCD CR in an unrelated namespace, tenant.
  2. Set its .spec.namespaceManagement to [{name: victim, allowManagedBy: true}].
  3. Remove that entry from the CR.

No NamespaceManagement CR or managed-by label authorizing the tenant instance is required in victim.

Actual behavior

The update predicate calls handleArgoCDNamespaceManagementUpdate, which passes the removed namespace to cleanupRBACsForNamespaceManagement. The cleanup deletes Roles and RoleBindings labeled app.kubernetes.io/part-of=argocd in victim, regardless of which instance owns them. Repeated updates can disrupt other Argo CD instances.

Relevant code: argocd-operator/controllers/argocd/util.go, particularly lines 1999–2015 and deleteRBACsForNamespace.

Expected behavior

Cleanup should delete only grants owned by the originating ArgoCD instance. Merely naming a namespace in the CR must not authorize deletion there. Add regression coverage for unrelated namespaces with the feature enabled and disabled, while preserving legitimate grant cleanup.

Confirmed at commit 5fb7a030 using an isolated fake-client reproduction through the update predicate; no live-cluster exploit was run.

(Bug text c/o OpenAI Codex v6.1 Sol xhigh)

Vorherrschende Sprache
Go
Sterne
190
Forks
367
Ø Merge
4 T. 2 Std.
Gemergte PRs (30 T.)
63

Entwicklungsumgebung

Erste Schritte

  1. Lesen Sie das ganze Issue und danach den Beitragsleitfaden des Projekts.
  2. Schreiben Sie ins Issue, dass Sie es übernehmen — das erspart doppelte Arbeit.
  3. Forken Sie das Repository und arbeiten Sie in einem Branch.
  4. Öffnen Sie einen Pull Request, der die Issue-Nummer nennt.

Mehr aus redhat-developer/gitops-operator

Alle Issues in redhat-developer/gitops-operator

Ähnliche Issues

Weitere Issues zu Go

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.