NamespaceManagement cleanup can delete RBAC in unrelated namespaces
维护者通常 1 天内回复
@Rizwana777 已经在做这个了。
开始于 2026年11月16日。
评估
调研方向
Start in argocd-operator/controllers/argocd/util.go around lines 1999-2015, where cleanupRBACsForNamespaceManagement is called from handleArgoCDNamespaceManagementUpdate, then read deleteRBACsForNamespace. Confirm the Roles and RoleBindings deleted there are not filtered by owning instance. Done means deletion is limited to grants owned by the originating ArgoCD, with regression tests for unrelated namespaces both with and without the feature flag.
由索引模型根据 Issue 内容生成。
描述
A user who can create and update an ArgoCD CR in their own namespace can cause the operator to delete Argo CD Roles and RoleBindings in another namespace, without permission or consent from that namespace. This also occurs when ALLOW_NAMESPACE_MANAGEMENT_IN_NAMESPACE_SCOPED_INSTANCES=false.
Reproduction
With a cluster-wide operator installation and existing Argo CD RBAC in namespace victim:
- Create an ArgoCD CR in an unrelated namespace,
tenant. - Set its
.spec.namespaceManagementto[{name: victim, allowManagedBy: true}]. - Remove that entry from the CR.
No NamespaceManagement CR or managed-by label authorizing the tenant instance is required in victim.
Actual behavior
The update predicate calls handleArgoCDNamespaceManagementUpdate, which passes the removed namespace to cleanupRBACsForNamespaceManagement. The cleanup deletes Roles and RoleBindings labeled app.kubernetes.io/part-of=argocd in victim, regardless of which instance owns them. Repeated updates can disrupt other Argo CD instances.
Relevant code: argocd-operator/controllers/argocd/util.go, particularly lines 1999–2015 and deleteRBACsForNamespace.
Expected behavior
Cleanup should delete only grants owned by the originating ArgoCD instance. Merely naming a namespace in the CR must not authorize deletion there. Add regression coverage for unrelated namespaces with the feature enabled and disabled, while preserving legitimate grant cleanup.
Confirmed at commit 5fb7a030 using an isolated fake-client reproduction through the update predicate; no live-cluster exploit was run.
(Bug text c/o OpenAI Codex v6.1 Sol xhigh)
- 主要语言
- Go
- 星标
- 190
- 派生
- 367
- 平均合并
- 4 天 2 小时
- 30 天内合并 PR
- 63
环境准备
- 提供 Dockerfile 或 Docker Compose 文件
- 有 Pull Request 模板
- 阅读贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
redhat-developer/gitops-operator 的其他 Issue
-
Manager does not detect Route CRD that appears after startup可能已有人在做 @atishay-kasliwal 今天认领。 未关闭
难度 4/5 3-5 天 新手友好度 48/100
redhat-developer/gitops-operator#1566 · 1 条评论 ·
维护者通常 1 天内回复
-
NamespaceManagement revocation checks labels on the wrong namespace可能已有人在做 @Rizwana777 于 3 天前认领。 未关闭kind/bug
难度 4/5 3-5 天 新手友好度 25/100
redhat-developer/gitops-operator#1559 · 1 条评论 · 已指派 1 人 ·
维护者通常 1 天内回复
-
Deleting an ArgoCD instance removes RBAC belonging to same-named instances可能已有人在做 @Rizwana777 于 3 天前认领。 未关闭kind/bug
难度 3/5 1-2 天 新手友好度 45/100
redhat-developer/gitops-operator#1558 · 已指派 1 人 ·
维护者通常 1 天内回复
-
ApplicationSet tokenRef strict mode changes only apply after the controller is restarted可能已有人在做 @Gabrielandre02 于 5 天前认领。 未关闭
redhat-developer/gitops-operator#1554 · 1 条评论 · 已指派 1 人 ·
维护者通常 1 天内回复
-
Enqueue the previous Argo CD instance when NamespaceManagement consent is withdrawn可能已有人在做 @Gabrielandre02 于 5 天前认领。 未关闭
难度 4/5 3-5 天 新手友好度 25/100
redhat-developer/gitops-operator#1530 · 1 条评论 ·
维护者通常 1 天内回复
查看 redhat-developer/gitops-operator 的全部 Issue
相似的 Issue
-
难度 2/5 1-3 小时 新手友好度 78/100
-
难度 2/5 1-3 小时 新手友好度 78/100
维护者通常 1 天内回复
-
Inconsistency between golang and cue in spec可能已有人在做 关联的 PR 仍在进行中或已合并。 未关闭
难度 1/5 1 小时以内 新手友好度 88/100
维护者通常 1 天内回复
-
security
难度 2/5 1-3 小时 新手友好度 68/100
-
难度 2/5 1-3 小时 新手友好度 73/100
Tencent/LoopForge#1087 · 1 条评论 ·
维护者通常 1 天内回复