Enqueue the previous Argo CD instance when NamespaceManagement consent is withdrawn

Offen
#1,530 1 Kommentar 0 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen

Maintainer antworten meist innerhalb von 1 Tag

@Gabrielandre02 arbeitet bereits daran.

Seit 13.11.2026.

Bewertung

Schwierigkeit
4/5
Geschätzter Aufwand
3-5 Tage
Anfängerfreundlichkeit
25/100
Issue-Typ
Bug
Klarheit
Klar beschrieben
Aktivitätsstatus
Veraltet
Tech-Stack
go, kubernetes
Bereich
backend, devops

Rechercherichtung

Read argocd-operator/controllers/argocd/util.go and the related mapper code, then inspect the event-path tests for NamespaceManagement changes. Trace deletion and reassignment when the managed-by label matches, and check how remaining valid consent affects enqueueing. Done when the event tests cover consent withdrawal and reconciliation removes stale Image Updater RBAC while existing cleanup tests still pass.

Vom Indexierungsmodell aus dem Issue-Text verfasst.

Beschreibung

Summary

NamespaceManagement deletion or reassignment can fail to enqueue the previously affected Argo CD instance. When the managing namespace has a matching managed-by label, the deletion predicate can skip cleanup and the instance may not reconcile. Image Updater RBAC grants in the target namespace can remain active until another reconciliation.

Required changes

Update the NamespaceManagement event handling in argocd-operator/controllers/argocd/util.go and related mapper code so deletion and reassignment enqueue the previously affected instance, including when predicate cleanup is skipped. Preserve existing cleanup behavior and account for any remaining valid consent.

Acceptance criteria

  • Deletion and reassignment enqueue the previously affected instance.
  • Event-path tests cover consent withdrawal, including the matching managed-by label case.
  • Tests verify that stale Image Updater RBAC is removed after reconciliation when no valid consent remains.
  • Existing cleanup behavior remains covered.

Requested by @dkarpele.

Pull request: https://github.com/redhat-developer/gitops-operator/pull/1511
Review comment: https://github.com/redhat-developer/gitops-operator/pull/1511#discussion_r4542576413

Vorherrschende Sprache
Go
Sterne
190
Forks
367
Ø Merge
4 T. 2 Std.
Gemergte PRs (30 T.)
63

Entwicklungsumgebung

Erste Schritte

  1. Lesen Sie das ganze Issue und danach den Beitragsleitfaden des Projekts.
  2. Schreiben Sie ins Issue, dass Sie es übernehmen — das erspart doppelte Arbeit.
  3. Forken Sie das Repository und arbeiten Sie in einem Branch.
  4. Öffnen Sie einen Pull Request, der die Issue-Nummer nennt.

Mehr aus redhat-developer/gitops-operator

Alle Issues in redhat-developer/gitops-operator

Ähnliche Issues

Weitere Issues zu Go

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.