Enqueue the previous Argo CD instance when NamespaceManagement consent is withdrawn

未關閉
#1,530 1 則留言 0 個 reaction 已指派 0 人 在 GitHub 檢視

維護者通常 1 天內回覆

@Gabrielandre02 已經在處理了。

開始於 2026年11月13日。

評估

難度
4/5
預估耗時
3-5 天
新手友好度
25/100
Issue 類型
缺陷
描述清晰度
描述清楚
活躍度
停滯
技術堆疊
go, kubernetes
領域
backend, devops

研究方向

Read argocd-operator/controllers/argocd/util.go and the related mapper code, then inspect the event-path tests for NamespaceManagement changes. Trace deletion and reassignment when the managed-by label matches, and check how remaining valid consent affects enqueueing. Done when the event tests cover consent withdrawal and reconciliation removes stale Image Updater RBAC while existing cleanup tests still pass.

由索引模型根據 Issue 內容生成。

描述

Summary

NamespaceManagement deletion or reassignment can fail to enqueue the previously affected Argo CD instance. When the managing namespace has a matching managed-by label, the deletion predicate can skip cleanup and the instance may not reconcile. Image Updater RBAC grants in the target namespace can remain active until another reconciliation.

Required changes

Update the NamespaceManagement event handling in argocd-operator/controllers/argocd/util.go and related mapper code so deletion and reassignment enqueue the previously affected instance, including when predicate cleanup is skipped. Preserve existing cleanup behavior and account for any remaining valid consent.

Acceptance criteria

  • Deletion and reassignment enqueue the previously affected instance.
  • Event-path tests cover consent withdrawal, including the matching managed-by label case.
  • Tests verify that stale Image Updater RBAC is removed after reconciliation when no valid consent remains.
  • Existing cleanup behavior remains covered.

Requested by @dkarpele.

Pull request: https://github.com/redhat-developer/gitops-operator/pull/1511
Review comment: https://github.com/redhat-developer/gitops-operator/pull/1511#discussion_r4542576413

主要語言
Go
星號
190
分支
367
平均合併
4 天 2 小時
30 天內合併 PR
63

環境準備

從這裡開始

  1. 先讀完整個 Issue,再讀專案的貢獻指南。
  2. 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
  3. Fork 儲存庫,在一個分支上完成修改。
  4. 送出 Pull Request,並在描述裡引用這個 Issue 編號。

redhat-developer/gitops-operator 的其他 Issue

查看 redhat-developer/gitops-operator 的全部 Issue

相似的 Issue

更多 Go Issue

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。