Hacktoberfest 2026: die Issues, die Maintainer für den Oktober markiert haben – offen und einsteigerfreundlich. Hacktoberfest-Issues durchsuchen

test_sampling_with_collapsed_export fails when the profiler records an unreadable frame

Offen Anfängerfreundlich
  • Stimmt etwas nicht?
#160,334 0 Kommentare 0 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen

Maintainer antworten meist innerhalb von 1 Tag

Dieses Issue hat noch niemand übernommen.

Bewertung

Schwierigkeit
2/5
Geschätzter Aufwand
1-3 Stunden
Anfängerfreundlichkeit
78/100
Issue-Typ
Bug
Klarheit
Klar beschrieben
Aktivitätsstatus
Aktiv
Tech-Stack
python
Bereich
testing

Rechercherichtung

Start with test_sampling_with_collapsed_export in Lib/test/test_profiling/test_sampling_profiler/test_integration.py and compare its colon assertion with the documented unreadable frame and GC frame output. The issue suggests accepting special <...> frames in this assertion; check related handling in test_binary_format.py for context. Done when the test accepts those special frames while still checking ordinary collapsed frames, and passes.

Vom Indexierungsmodell aus dem Issue-Text verfasst.

Beschreibung

tests topic-profiling type-bug

Bug report

Bug description:

test_sampling_with_collapsed_export failed in the ASan job of my PR gh-160296 (the change there is in a multiprocessing test and is unrelated):

FAIL: test_sampling_with_collapsed_export (test.test_profiling.test_sampling_profiler.test_integration.TestSampleProfilerIntegration.test_sampling_with_collapsed_export)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/runner/work/cpython/cpython/Lib/test/test_profiling/test_sampling_profiler/test_integration.py", line 512, in test_sampling_with_collapsed_export
    self.assertIn(":", part)
    ~~~~~~~~~~~~~^^^^^^^^^^^
AssertionError: ':' not found in '<unreadable frame>'

https://github.com/python/cpython/actions/runs/39832455069/job/120012213367

Since gh-154194, _remote_debugging returns a degraded frame (file "~", no location, function "<unreadable frame>") when it cannot read a code object, instead of failing the sample. CollapsedStackCollector turns the None location into line 0, and export() writes frames with file "~" and line 0 as just the function name, so the collapsed line contains <unreadable frame> with no colon. The test expects every part to look like file:func:line, so it fails whenever a sample hits an unreadable frame. I have only seen it on the ASan build so far.

gh-154195 updated test_binary_format.py for the new frame, but not this test.

Reproducer, without a target process:

import os
import tempfile
from profiling.sampling.stack_collector import CollapsedStackCollector

collector = CollapsedStackCollector(1000)
# The first (innermost) frame is what _remote_debugging returns
# when it cannot read a code object (gh-154194).
frames = [
    ("~", None, "<unreadable frame>", None),
    ("/tmp/script.py", (10, 10, 0, 1), "main", None),
]
collector.process_frames(frames, thread_id=1)

fd, path = tempfile.mkstemp(suffix=".txt")
os.close(fd)
collector.export(path)
with open(path) as f:
    line = f.read().strip()
os.unlink(path)

print(line)
stack_trace = line.rsplit(" ", 1)[0]
for part in stack_trace.split(";"):
    print(repr(part), ":" in part)

Output:

Collapsed stack output written to /tmp/tmp....txt
tid:1;script.py:main:10;<unreadable frame> 1
'tid:1' True
'script.py:main:10' True
'<unreadable frame>' False

<GC> frames (on by default in sample()) take the same "~" branch in export(), so they would fail this assertion too. The test could accept these special <...> frames instead of requiring a colon. I can open a PR if that approach is fine.

The same test and the gh-154194 change are also in 3.15.

CPython versions tested on:

CPython main branch

Operating systems tested on:

Linux, macOS

Vorherrschende Sprache
Python
Sterne
77.7k
Forks
38.3k
Ø Merge
12 Std. 27 Min.
Gemergte PRs (30 T.)
645

Entwicklungsumgebung

In Codespaces öffnen

Startet den Dev-Container des Projekts im Browser, mit Ihrem eigenen GitHub-Konto.

Erste Schritte

  1. Lesen Sie das ganze Issue und danach den Beitragsleitfaden des Projekts.
  2. Schreiben Sie ins Issue, dass Sie es übernehmen — das erspart doppelte Arbeit.
  3. Forken Sie das Repository und arbeiten Sie in einem Branch.
  4. Öffnen Sie einen Pull Request, der die Issue-Nummer nennt.

Mehr aus python/cpython

Alle Issues in python/cpython

Ähnliche Issues

Weitere Issues zu Python

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.