Hacktoberfest 2026：維護者為十月標記出來的 issue，仍然開放、適合新手。 瀏覽 Hacktoberfest issue

test_sampling_with_collapsed_export fails when the profiler records an unreadable frame

未關閉 適合新手
  • 哪裡不對？
#160,334 1 則留言 0 個 reaction 已指派 0 人 在 GitHub 檢視

維護者通常 1 天內回覆

還沒有人認領這個 Issue。

評估

難度
2/5
預估耗時
1-3 小時
新手友好度
78/100
Issue 類型
缺陷
描述清晰度
描述清楚
活躍度
活躍
技術堆疊
python
領域
testing

研究方向

Start with test_sampling_with_collapsed_export in Lib/test/test_profiling/test_sampling_profiler/test_integration.py and compare its colon assertion with the documented unreadable frame and GC frame output. The issue suggests accepting special <...> frames in this assertion; check related handling in test_binary_format.py for context. Done when the test accepts those special frames while still checking ordinary collapsed frames, and passes.

由索引模型根據 Issue 內容生成。

描述

tests topic-profiling type-bug

Bug report

Bug description:

test_sampling_with_collapsed_export failed in the ASan job of my PR gh-160296 (the change there is in a multiprocessing test and is unrelated):

FAIL: test_sampling_with_collapsed_export (test.test_profiling.test_sampling_profiler.test_integration.TestSampleProfilerIntegration.test_sampling_with_collapsed_export)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/runner/work/cpython/cpython/Lib/test/test_profiling/test_sampling_profiler/test_integration.py", line 512, in test_sampling_with_collapsed_export
    self.assertIn(":", part)
    ~~~~~~~~~~~~~^^^^^^^^^^^
AssertionError: ':' not found in '<unreadable frame>'

https://github.com/python/cpython/actions/runs/39832455069/job/120012213367

Since gh-154194, _remote_debugging returns a degraded frame (file "~", no location, function "<unreadable frame>") when it cannot read a code object, instead of failing the sample. CollapsedStackCollector turns the None location into line 0, and export() writes frames with file "~" and line 0 as just the function name, so the collapsed line contains <unreadable frame> with no colon. The test expects every part to look like file:func:line, so it fails whenever a sample hits an unreadable frame. I have only seen it on the ASan build so far.

gh-154195 updated test_binary_format.py for the new frame, but not this test.

Reproducer, without a target process:

import os
import tempfile
from profiling.sampling.stack_collector import CollapsedStackCollector

collector = CollapsedStackCollector(1000)
# The first (innermost) frame is what _remote_debugging returns
# when it cannot read a code object (gh-154194).
frames = [
    ("~", None, "<unreadable frame>", None),
    ("/tmp/script.py", (10, 10, 0, 1), "main", None),
]
collector.process_frames(frames, thread_id=1)

fd, path = tempfile.mkstemp(suffix=".txt")
os.close(fd)
collector.export(path)
with open(path) as f:
    line = f.read().strip()
os.unlink(path)

print(line)
stack_trace = line.rsplit(" ", 1)[0]
for part in stack_trace.split(";"):
    print(repr(part), ":" in part)

Output:

Collapsed stack output written to /tmp/tmp....txt
tid:1;script.py:main:10;<unreadable frame> 1
'tid:1' True
'script.py:main:10' True
'<unreadable frame>' False

<GC> frames (on by default in sample()) take the same "~" branch in export(), so they would fail this assertion too. The test could accept these special <...> frames instead of requiring a colon. I can open a PR if that approach is fine.

The same test and the gh-154194 change are also in 3.15.

CPython versions tested on:

CPython main branch

Operating systems tested on:

Linux, macOS

主要語言
Python
星號
77.7k
分支
38.3k
平均合併
12 小時 12 分鐘
30 天內合併 PR
650

環境準備

在 Codespaces 中開啟

在瀏覽器裡用你自己的 GitHub 帳號啟動這個專案的開發容器。

從這裡開始

  1. 先讀完整個 Issue，再讀專案的貢獻指南。
  2. 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
  3. Fork 儲存庫，在一個分支上完成修改。
  4. 送出 Pull Request，並在描述裡引用這個 Issue 編號。

python/cpython 的其他 Issue

查看 python/cpython 的全部 Issue

相似的 Issue

更多 Python Issue

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。