Implement nonlocal variables scoping rule for rename refactor

Offen
  • Stimmt etwas nicht?
#935 0 Kommentare 0 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen

Maintainer antworten meist innerhalb von 2 Tagen

@ryanchou1994 arbeitet bereits daran.

Seit 06.11.2026.

  • #936 von @ryanchou1994 — offen

Bewertung

Schwierigkeit
4/5
Geschätzter Aufwand
3-5 Tage
Anfängerfreundlichkeit
48/100
Issue-Typ
Feature
Klarheit
Größtenteils klar
Aktivitätsstatus
Aktiv
Tech-Stack
python
Bereich
developer-experience, tooling

Rechercherichtung

Start by reading the rename refactor implementation and its tests for variable scope handling; the issue does not name specific files or tests. Trace how definitions and references are resolved across nested functions, then add coverage for the nonlocal cases in the example. Done means renaming the variable defined in outer updates its nested nonlocal references and read, while leaving the global name and inner4 variable unchanged.

Vom Indexierungsmodell aus dem Issue-Text verfasst.

Beschreibung

bug

Is your feature request related to a problem? Please describe.

Rename refactor does not understand nonlocal variables scoping rules at all.

Describe the solution you'd like

Given this code:

var_x = "global"   # shadowed variable in global scope should not be renamed
def outer():
    def inner1():
        nonlocal var_x   # when renaming this
        var_x = 1
    def inner2():
        nonlocal var_x   # declared nonlocal from a different inner function, should be renamed
        var_x = 2
    def inner3():
        print(var_x)   # undeclared read-only nonlocal, should be renamed
    def inner4():
        var_x = 4   # this creates separate scope, should not be renamed 
    var_x = None  # this is the definition location of the var_x, should be renamed
    return var_x

Currently rename refactor only rename variables in one function at a time.

  1. Expected code after refactoring: All instances of var_x insider outer, except inner4 should be renamed.

  2. Describe the error or unexpected result that you are getting: currently, each function gets treated as their own scope and inner functions variables don't get renamed and vice versa

Editor information (please complete the following information):

  • Rope version: 1.15.2
Vorherrschende Sprache
Python
Sterne
2.2k
Forks
197
Ø Merge
1 T. 20 Std.
Gemergte PRs (30 T.)
7

Entwicklungsumgebung

Erste Schritte

  1. Lesen Sie das ganze Issue und danach den Beitragsleitfaden des Projekts.
  2. Schreiben Sie ins Issue, dass Sie es übernehmen — das erspart doppelte Arbeit.
  3. Forken Sie das Repository und arbeiten Sie in einem Branch.
  4. Öffnen Sie einen Pull Request, der die Issue-Nummer nennt.

Mehr aus python-rope/rope

Alle Issues in python-rope/rope

Ähnliche Issues

Weitere Issues zu Python

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.