Implement nonlocal variables scoping rule for rename refactor

Aberta
  • Algo errado?
#935 0 comentários 0 reações 0 responsáveis Ver no GitHub

Mantenedores costumam responder em até 2 dias

@ryanchou1994 já está trabalhando nisso.

Desde 6/11/2026.

  • #936 de @ryanchou1994 — aberto

Avaliação

Dificuldade
4/5
Tempo estimado
3-5 dias
Facilidade para iniciantes
48/100
Tipo de issue
Funcionalidade
Clareza
Razoavelmente clara
Status de atividade
Ativa
Stack de tecnologia
python
Domínio
developer-experience, tooling

Direção de pesquisa

Start by reading the rename refactor implementation and its tests for variable scope handling; the issue does not name specific files or tests. Trace how definitions and references are resolved across nested functions, then add coverage for the nonlocal cases in the example. Done means renaming the variable defined in outer updates its nested nonlocal references and read, while leaving the global name and inner4 variable unchanged.

Escrita pelo modelo de indexação a partir do texto da issue.

Descrição

bug

Is your feature request related to a problem? Please describe.

Rename refactor does not understand nonlocal variables scoping rules at all.

Describe the solution you'd like

Given this code:

var_x = "global"        # shadowed variable in global scope should not be renamed

def outer():
    def inner1():
        nonlocal var_x  # when renaming this
        var_x = 1

    def inner2():
        nonlocal var_x  # declared nonlocal from a different inner function, should be renamed
        var_x = 2

    def inner3():
        print(var_x)    # undeclared read-only nonlocal, should be renamed

    def inner4():
        var_x = 4       # this creates separate scope, should not be renamed 
 
   var_x = None        # this is the definition location of the var_x, should be renamed
    # var_x: int        # variable can also be declared by type hint without assignment

    return var_x

Currently rename refactor only rename variables in one function at a time.

  1. Expected code after refactoring: All instances of var_x insider outer, except inner4 should be renamed.

  2. Describe the error or unexpected result that you are getting: currently, each function gets treated as their own scope and inner functions variables don't get renamed and vice versa

Editor information (please complete the following information):

  • Rope version: 1.15.2
Linguagem predominante
Python
Estrelas
2.2k
Forks
197
Merge médio
1d 20h
PRs com merge (30d)
7

Preparar o ambiente

Primeiros passos

  1. Leia a issue inteira e depois o guia de contribuição do projeto.
  2. Comente na issue dizendo que vai assumir — evita que duas pessoas façam o mesmo trabalho.
  3. Faça um fork do repositório e trabalhe em uma branch.
  4. Abra um pull request que referencie o número da issue.

Mais de python-rope/rope

Todas as issues de python-rope/rope

Issues semelhantes

Mais issues de Python

Receba novas issues na sua caixa de entrada

Um resumo curto de issues do GitHub para quem está começando.