Implement nonlocal variables scoping rule for rename refactor

Abierto
  • ¿Algo no está bien?
#935 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 2 días

@ryanchou1994 ya está trabajando en esto.

Desde el 6/11/2026.

  • #936 de @ryanchou1994 — abierto

Evaluación

Dificultad
4/5
Tiempo estimado
3-5 días
Aptitud para principiantes
48/100
Tipo de issue
Nueva funcionalidad
Claridad
Bastante claro
Estado de actividad
Activo
Stack tecnológico
python
Área
developer-experience, tooling

Línea de trabajo

Start by reading the rename refactor implementation and its tests for variable scope handling; the issue does not name specific files or tests. Trace how definitions and references are resolved across nested functions, then add coverage for the nonlocal cases in the example. Done means renaming the variable defined in outer updates its nested nonlocal references and read, while leaving the global name and inner4 variable unchanged.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

bug

Is your feature request related to a problem? Please describe.

Rename refactor does not understand nonlocal variables scoping rules at all.

Describe the solution you'd like

Given this code:

var_x = "global"   # shadowed variable in global scope should not be renamed
def outer():
    def inner1():
        nonlocal var_x   # when renaming this
        var_x = 1
    def inner2():
        nonlocal var_x   # declared nonlocal from a different inner function, should be renamed
        var_x = 2
    def inner3():
        print(var_x)   # undeclared read-only nonlocal, should be renamed
    def inner4():
        var_x = 4   # this creates separate scope, should not be renamed 
    var_x = None  # this is the definition location of the var_x, should be renamed
    return var_x

Currently rename refactor only rename variables in one function at a time.

  1. Expected code after refactoring: All instances of var_x insider outer, except inner4 should be renamed.

  2. Describe the error or unexpected result that you are getting: currently, each function gets treated as their own scope and inner functions variables don't get renamed and vice versa

Editor information (please complete the following information):

  • Rope version: 1.15.2
Lenguaje dominante
Python
Estrellas
2.2k
Forks
197
Merge medio
1 d 20 h
PR fusionados (30 d)
7

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de python-rope/rope

Todos los issues de python-rope/rope

Issues similares

Más issues de Python

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.