CallbackService.run()/arun() should support a configurable timeout

Offen
#15 0 Kommentare 0 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen

Dieses Issue hat noch niemand übernommen.

Bewertung

Schwierigkeit
4/5
Geschätzter Aufwand
3-5 Tage
Anfängerfreundlichkeit
45/100
Issue-Typ
Feature
Klarheit
Größtenteils klar
Aktivitätsstatus
Ruhig
Tech-Stack
python
Bereich
backend

Rechercherichtung

Start with CallbackService.run() and arun(), then inspect the pulp_workflow.app.tasks.run_callback dispatch path and the corresponding SigningService.sign()/asign() behavior in pulpcore. Determine how a configurable default timeout should apply to both subprocess paths and how it should align with the upstream signing-service pattern. Done means the timeout behavior and its tests cover synchronous and asynchronous callbacks without leaving a hung process.

Vom Indexierungsmodell aus dem Issue-Text verfasst.

Beschreibung

enhancement

CallbackService.run() and arun() invoke a user-supplied script via
subprocess.run(...) / asyncio.create_subprocess_exec(...) with no timeout,
so a hung callback (e.g. a script that makes an HTTP call without its own
client-side timeout) will pin a Pulp worker indefinitely until the worker is
restarted or the process is killed externally.

Mitigations already in place:

  • Callbacks are dispatched as their own Pulp tasks
    (pulp_workflow.app.tasks.run_callback), so a hung callback ties up a worker
    slot but does not stall the originating workflow's state machine.
  • Only admins (callbackservice_admin) can register callback scripts, so this
    is a self-inflicted-foot-gun rather than an unauthenticated DoS surface.

Notes:

  • This mirrors pulpcore.app.models.SigningService.sign() / asign() exactly,
    which also have no timeout. Adding a timeout knob here without doing the
    same for SigningService upstream would diverge from the established
    pattern.
  • Suggested shape if/when this is addressed: a WORKFLOW_CALLBACK_TIMEOUT
    setting (default e.g. 300s), passed to subprocess.run(..., timeout=...) in
    run() and wrapped with asyncio.wait_for(process.communicate(), ...) plus
    process.kill() on TimeoutError in arun(). Ideally pushed upstream into
    SigningService as well so both inherit the same behavior.

Originally raised by the Copilot reviewer on #11.

Vorherrschende Sprache
Python
Sterne
1
Forks
3
Ø Merge
2 T. 2 Std.
Gemergte PRs (30 T.)
7

Entwicklungsumgebung

Erste Schritte

  1. Lesen Sie das ganze Issue und danach den Beitragsleitfaden des Projekts.
  2. Schreiben Sie ins Issue, dass Sie es übernehmen — das erspart doppelte Arbeit.
  3. Forken Sie das Repository und arbeiten Sie in einem Branch.
  4. Öffnen Sie einen Pull Request, der die Issue-Nummer nennt.

Mehr aus pulp/pulp_workflow

Alle Issues in pulp/pulp_workflow

Ähnliche Issues

Weitere Issues zu Python

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.