CallbackService.run()/arun() should support a configurable timeout

Ouverte
#15 0 commentaires 0 réactions 0 personnes assignées Voir sur GitHub

Personne n'a encore pris cette issue.

Évaluation

Difficulté
4/5
Temps estimé
3-5 jours
Accessibilité débutants
45/100
Type d'issue
Fonctionnalité
Clarté
Plutôt claire
Activité
Calme
Stack technique
python
Domaine
backend

Piste de recherche

Start with CallbackService.run() and arun(), then inspect the pulp_workflow.app.tasks.run_callback dispatch path and the corresponding SigningService.sign()/asign() behavior in pulpcore. Determine how a configurable default timeout should apply to both subprocess paths and how it should align with the upstream signing-service pattern. Done means the timeout behavior and its tests cover synchronous and asynchronous callbacks without leaving a hung process.

Rédigé par le modèle d'indexation à partir du texte de l'issue.

Description

enhancement

CallbackService.run() and arun() invoke a user-supplied script via
subprocess.run(...) / asyncio.create_subprocess_exec(...) with no timeout,
so a hung callback (e.g. a script that makes an HTTP call without its own
client-side timeout) will pin a Pulp worker indefinitely until the worker is
restarted or the process is killed externally.

Mitigations already in place:

  • Callbacks are dispatched as their own Pulp tasks
    (pulp_workflow.app.tasks.run_callback), so a hung callback ties up a worker
    slot but does not stall the originating workflow's state machine.
  • Only admins (callbackservice_admin) can register callback scripts, so this
    is a self-inflicted-foot-gun rather than an unauthenticated DoS surface.

Notes:

  • This mirrors pulpcore.app.models.SigningService.sign() / asign() exactly,
    which also have no timeout. Adding a timeout knob here without doing the
    same for SigningService upstream would diverge from the established
    pattern.
  • Suggested shape if/when this is addressed: a WORKFLOW_CALLBACK_TIMEOUT
    setting (default e.g. 300s), passed to subprocess.run(..., timeout=...) in
    run() and wrapped with asyncio.wait_for(process.communicate(), ...) plus
    process.kill() on TimeoutError in arun(). Ideally pushed upstream into
    SigningService as well so both inherit the same behavior.

Originally raised by the Copilot reviewer on #11.

Langage dominant
Python
Étoiles
1
Forks
3
Merge moyen
2 j 2 h
PR mergées (30 j)
7

Préparer son environnement

Par où commencer

  1. Lisez l'issue en entier, puis le guide de contribution du projet.
  2. Signalez en commentaire que vous la prenez — cela évite que deux personnes fassent le même travail.
  3. Forkez le dépôt et travaillez sur une branche.
  4. Ouvrez une pull request qui référence le numéro de l'issue.

Autres issues de pulp/pulp_workflow

Toutes les issues de pulp/pulp_workflow

Issues similaires

Plus d'issues Python

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.