CallbackService.run()/arun() should support a configurable timeout

Abierto
#15 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
4/5
Tiempo estimado
3-5 días
Aptitud para principiantes
45/100
Tipo de issue
Nueva funcionalidad
Claridad
Bastante claro
Estado de actividad
Tranquilo
Stack tecnológico
python
Área
backend

Línea de trabajo

Start with CallbackService.run() and arun(), then inspect the pulp_workflow.app.tasks.run_callback dispatch path and the corresponding SigningService.sign()/asign() behavior in pulpcore. Determine how a configurable default timeout should apply to both subprocess paths and how it should align with the upstream signing-service pattern. Done means the timeout behavior and its tests cover synchronous and asynchronous callbacks without leaving a hung process.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

enhancement

CallbackService.run() and arun() invoke a user-supplied script via
subprocess.run(...) / asyncio.create_subprocess_exec(...) with no timeout,
so a hung callback (e.g. a script that makes an HTTP call without its own
client-side timeout) will pin a Pulp worker indefinitely until the worker is
restarted or the process is killed externally.

Mitigations already in place:

  • Callbacks are dispatched as their own Pulp tasks
    (pulp_workflow.app.tasks.run_callback), so a hung callback ties up a worker
    slot but does not stall the originating workflow's state machine.
  • Only admins (callbackservice_admin) can register callback scripts, so this
    is a self-inflicted-foot-gun rather than an unauthenticated DoS surface.

Notes:

  • This mirrors pulpcore.app.models.SigningService.sign() / asign() exactly,
    which also have no timeout. Adding a timeout knob here without doing the
    same for SigningService upstream would diverge from the established
    pattern.
  • Suggested shape if/when this is addressed: a WORKFLOW_CALLBACK_TIMEOUT
    setting (default e.g. 300s), passed to subprocess.run(..., timeout=...) in
    run() and wrapped with asyncio.wait_for(process.communicate(), ...) plus
    process.kill() on TimeoutError in arun(). Ideally pushed upstream into
    SigningService as well so both inherit the same behavior.

Originally raised by the Copilot reviewer on #11.

Lenguaje dominante
Python
Estrellas
1
Forks
3
Merge medio
2 d 2 h
PR fusionados (30 d)
7

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de pulp/pulp_workflow

Todos los issues de pulp/pulp_workflow

Issues similares

Más issues de Python

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.