[Bug]: SSH reconnect fails for as long as the old remote server is stuck shutting down

Offen
#39,797 0 Kommentare 0 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen

Maintainer antworten meist innerhalb von 1 Tag

Dieses Issue hat noch niemand übernommen.

Bewertung

Schwierigkeit
4/5
Geschätzter Aufwand
3-5 Tage
Anfängerfreundlichkeit
48/100
Issue-Typ
Bug
Klarheit
Größtenteils klar
Aktivitätsstatus
Aktiv
Tech-Stack
typescript
Bereich
backend, networking

Rechercherichtung

Start with the reconnect launch script in packages/ssh/src/tunnel.ts, especially the managed_server_running check and wait_ready path. Trace how the remote server's runtime record and shutdown lifecycle are handled, including the mentioned releaseManagedTunnelOnShutdown path. Run the SSH reconnect tests and add coverage for a live server whose listener has closed; done means reconnect recovers or reports the previous process is still shutting down.

Vom Indexierungsmodell aus dem Issue-Text verfasst.

Beschreibung

Version: desktop and remote runtime 0.1.11-nightly.20261118.4890. Remote is an arm64 Linux VM reached over SSH.

What happened

The remote t3 serve process received SIGTERM and began shutting down. It closed its HTTP listener, but it could not exit, because one of its worker threads was blocked in an uninterruptible filesystem wait (a slow fsync on the VM). For the next ~22 minutes, every reconnect from the desktop failed with:

Remote T3 server is still running but did not become ready. Retry the connection; the server was left running.

Each retry spent about 70 s inside launchOrReuseRemoteServer before failing. The connection came back only after the old process finally exited.

Cause

In packages/ssh/src/tunnel.ts, the launch script checks managed_server_running "$REMOTE_PID", which tests only kill -0 plus the process's command line. A server that is mid-shutdown passes that check. The script then runs wait_ready, which can never succeed because the listener is closed, and the script exits 1 with "the server was left running". Nothing in the reconnect path can tell "alive but slow" apart from "alive but shutting down", so the desktop retries the same failing path indefinitely.

Observed on the remote during the outage:

  • The pid was alive in state S. Its main thread was in epoll_pwait and one WorkerThread was in D (wait_for_commit).
  • curl http://127.0.0.1:3773/ was refused immediately (no listener).
  • The trace showed environment.cloud.releaseManagedTunnelOnShutdown and the root server.runServerCommand fibers being interrupted, so teardown had started but not finished.

Expected

The reconnect either recovers or reports what is actually wrong. Options:

  • The server marks its runtime record as stopping when teardown begins, and the launcher treats a stopping server as gone: it waits a bounded time, then starts a fresh server or fails with "the previous server (pid N) is still shutting down".
  • At minimum, when the port is refused (as opposed to timing out), the launcher should not say the server "did not become ready".

Created with Claude Opus 5.5 in Claude Code.

Vorherrschende Sprache
TypeScript
Sterne
24.8k
Forks
6.4k
Ø Merge
4 Std. 29 Min.
Gemergte PRs (30 T.)
488

Entwicklungsumgebung

In Codespaces öffnen

Startet den Dev-Container des Projekts im Browser, mit Ihrem eigenen GitHub-Konto.

Erste Schritte

  1. Lesen Sie das ganze Issue und danach den Beitragsleitfaden des Projekts.
  2. Schreiben Sie ins Issue, dass Sie es übernehmen — das erspart doppelte Arbeit.
  3. Forken Sie das Repository und arbeiten Sie in einem Branch.
  4. Öffnen Sie einen Pull Request, der die Issue-Nummer nennt.

Mehr aus pingdotgg/t3code

Alle Issues in pingdotgg/t3code

Ähnliche Issues

Weitere Issues zu TypeScript

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.