[Bug]: SSH reconnect fails for as long as the old remote server is stuck shutting down

Đang mở
#39,797 0 bình luận 0 reaction 0 người được giao Xem trên GitHub

Maintainer thường phản hồi trong vòng 1 ngày

Chưa có ai nhận issue này.

Đánh giá

Độ khó
4/5
Thời gian dự kiến
3-5 ngày
Mức phù hợp với người mới
48/100
Loại issue
Lỗi
Độ rõ ràng
Khá rõ ràng
Mức độ hoạt động
Sôi nổi
Công nghệ
typescript
Lĩnh vực
backend, networking

Hướng nghiên cứu

Start with the reconnect launch script in packages/ssh/src/tunnel.ts, especially the managed_server_running check and wait_ready path. Trace how the remote server's runtime record and shutdown lifecycle are handled, including the mentioned releaseManagedTunnelOnShutdown path. Run the SSH reconnect tests and add coverage for a live server whose listener has closed; done means reconnect recovers or reports the previous process is still shutting down.

Do mô hình lập chỉ mục viết ra từ nội dung của issue.

Mô tả

Version: desktop and remote runtime 0.1.11-nightly.20261118.4890. Remote is an arm64 Linux VM reached over SSH.

What happened

The remote t3 serve process received SIGTERM and began shutting down. It closed its HTTP listener, but it could not exit, because one of its worker threads was blocked in an uninterruptible filesystem wait (a slow fsync on the VM). For the next ~22 minutes, every reconnect from the desktop failed with:

Remote T3 server is still running but did not become ready. Retry the connection; the server was left running.

Each retry spent about 70 s inside launchOrReuseRemoteServer before failing. The connection came back only after the old process finally exited.

Cause

In packages/ssh/src/tunnel.ts, the launch script checks managed_server_running "$REMOTE_PID", which tests only kill -0 plus the process's command line. A server that is mid-shutdown passes that check. The script then runs wait_ready, which can never succeed because the listener is closed, and the script exits 1 with "the server was left running". Nothing in the reconnect path can tell "alive but slow" apart from "alive but shutting down", so the desktop retries the same failing path indefinitely.

Observed on the remote during the outage:

  • The pid was alive in state S. Its main thread was in epoll_pwait and one WorkerThread was in D (wait_for_commit).
  • curl http://127.0.0.1:3773/ was refused immediately (no listener).
  • The trace showed environment.cloud.releaseManagedTunnelOnShutdown and the root server.runServerCommand fibers being interrupted, so teardown had started but not finished.

Expected

The reconnect either recovers or reports what is actually wrong. Options:

  • The server marks its runtime record as stopping when teardown begins, and the launcher treats a stopping server as gone: it waits a bounded time, then starts a fresh server or fails with "the previous server (pid N) is still shutting down".
  • At minimum, when the port is refused (as opposed to timing out), the launcher should not say the server "did not become ready".

Created with Claude Opus 5.5 in Claude Code.

Ngôn ngữ chính
TypeScript
Star
24.8k
Fork
6.4k
Merge trung bình
4 giờ 29 phút
Pull request đã merge (30 ngày)
488

Chuẩn bị môi trường

Mở trong Codespaces

Khởi chạy dev container của dự án ngay trên trình duyệt, bằng tài khoản GitHub của bạn.

Bắt đầu từ đâu

  1. Đọc hết issue, rồi đọc hướng dẫn đóng góp của dự án.
  2. Bình luận trên issue rằng bạn sẽ nhận — tránh hai người làm cùng một việc.
  3. Fork repository và làm thay đổi trên một nhánh.
  4. Mở pull request có tham chiếu số hiệu của issue.

Issue khác của pingdotgg/t3code

Tất cả issue của pingdotgg/t3code

Issue tương tự

Thêm issue về TypeScript

Nhận issue mới trong hộp thư của bạn

Bản tóm tắt ngắn những issue GitHub phù hợp với người mới.