[Bug]: SSH reconnect fails for as long as the old remote server is stuck shutting down

Aperta
#39,797 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
4/5
Tempo stimato
3-5 giorni
Idoneità per principianti
48/100
Tipo di issue
Bug
Chiarezza
Abbastanza chiara
Stato di attività
Attiva
Stack tecnologico
typescript

Direzione di ricerca

Start with the reconnect launch script in packages/ssh/src/tunnel.ts, especially the managed_server_running check and wait_ready path. Trace how the remote server's runtime record and shutdown lifecycle are handled, including the mentioned releaseManagedTunnelOnShutdown path. Run the SSH reconnect tests and add coverage for a live server whose listener has closed; done means reconnect recovers or reports the previous process is still shutting down.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

Version: desktop and remote runtime 0.1.11-nightly.20261118.4890. Remote is an arm64 Linux VM reached over SSH.

What happened

The remote t3 serve process received SIGTERM and began shutting down. It closed its HTTP listener, but it could not exit, because one of its worker threads was blocked in an uninterruptible filesystem wait (a slow fsync on the VM). For the next ~22 minutes, every reconnect from the desktop failed with:

Remote T3 server is still running but did not become ready. Retry the connection; the server was left running.

Each retry spent about 70 s inside launchOrReuseRemoteServer before failing. The connection came back only after the old process finally exited.

Cause

In packages/ssh/src/tunnel.ts, the launch script checks managed_server_running "$REMOTE_PID", which tests only kill -0 plus the process's command line. A server that is mid-shutdown passes that check. The script then runs wait_ready, which can never succeed because the listener is closed, and the script exits 1 with "the server was left running". Nothing in the reconnect path can tell "alive but slow" apart from "alive but shutting down", so the desktop retries the same failing path indefinitely.

Observed on the remote during the outage:

  • The pid was alive in state S. Its main thread was in epoll_pwait and one WorkerThread was in D (wait_for_commit).
  • curl http://127.0.0.1:3773/ was refused immediately (no listener).
  • The trace showed environment.cloud.releaseManagedTunnelOnShutdown and the root server.runServerCommand fibers being interrupted, so teardown had started but not finished.

Expected

The reconnect either recovers or reports what is actually wrong. Options:

  • The server marks its runtime record as stopping when teardown begins, and the launcher treats a stopping server as gone: it waits a bounded time, then starts a fresh server or fails with "the previous server (pid N) is still shutting down".
  • At minimum, when the port is refused (as opposed to timing out), the launcher should not say the server "did not become ready".

Created with Claude Opus 5.5 in Claude Code.

Lingua principale
TypeScript
Stelle
24.8k
Fork
6.4k
Merge medio
4h 29m
PR unite (30g)
488

Preparare l'ambiente

Apri in Codespaces

Avvia il container di sviluppo del progetto nel browser, con il tuo account GitHub.

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di pingdotgg/t3code

Tutte le issue di pingdotgg/t3code

Issue simili

Altre issue su TypeScript

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.