storage: let one gold deposit or withdrawal move more than the current per-transaction cap

Offen
#3,355 2 Kommentare 0 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen

Maintainer antworten meist innerhalb von 1 Tag

Dieses Issue hat noch niemand übernommen.

Bewertung

Schwierigkeit
3/5
Geschätzter Aufwand
Ein halber Tag
Anfängerfreundlichkeit
40/100
Issue-Typ
Feature
Klarheit
Größtenteils klar
Aktivitätsstatus
Aktiv
Tech-Stack
go, typescript
Bereich
backend, frontend

Rechercherichtung

Start with the native cap at apps/client-next/src/engine/foundation/gameplay/storage-room.ts (line 59) and find where SRO_RAISED_GOLD_CAPS sets the 1,000,000,000 limit for the dialog and the server check. Check GoldAmount in apps/server/internal/game/item/wire/itemmove.go, since the u32 bound caps what one move can carry. Done when the shard-chosen limit is applied to both the dialog and the server, and a test shows a deposit and withdrawal above 1,000,000,000 under the raised rule while the 100,000,000 cap still holds without it.

Vom Indexierungsmodell aus dem Issue-Text verfasst.

Beschreibung

area: server enhancement priority: low

Player report BR-261112-0210-41A6 (in-game, 2026-11-12, thread 1570259499703345253 is the mall report; this is BR-261111-2056-1800, thread 1570180473551065089): gold cannot be deposited to or withdrawn from storage in amounts above the per-transaction cap; the player asks to move as much as they want in one transaction.

Not a bug: the cap is deliberate. The original caps one warehouse gold deposit at 100,000,000 (client 59A430, recorded at apps/client-next/src/engine/foundation/gameplay/storage-room.ts:59); this shard runs the port-only SRO_RAISED_GOLD_CAPS rule, which raises the dialog and the server check to 1,000,000,000 - the limit the player is hitting. The ask is to raise it further. One wire bound: a single gold move carries a u32 amount (apps/server/internal/game/item/wire/itemmove.go GoldAmount), so one transaction cannot exceed 4,294,967,295 without a wire change; the balance itself is 64-bit.

Done when: the raised-caps limit is a value the shard can choose (for example up to the wire bound), with the dialog and the server check agreeing, and a test pins a deposit and a withdrawal above 1,000,000,000 under the raised rule while the native 100,000,000 cap still applies without it.

Vorherrschende Sprache
Go
Sterne
97
Forks
61
Ø Merge
4 Std. 14 Min.
Gemergte PRs (30 T.)
913

Entwicklungsumgebung

Erste Schritte

  1. Lesen Sie das ganze Issue und danach den Beitragsleitfaden des Projekts.
  2. Schreiben Sie ins Issue, dass Sie es übernehmen — das erspart doppelte Arbeit.
  3. Forken Sie das Repository und arbeiten Sie in einem Branch.
  4. Öffnen Sie einen Pull Request, der die Issue-Nummer nennt.

Mehr aus opensro-dev/opensro

Alle Issues in opensro-dev/opensro

Ähnliche Issues

Weitere Issues zu Go

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.