storage: let one gold deposit or withdrawal move more than the current per-transaction cap

Aberta
#3,355 2 comentários 0 reações 0 responsáveis Ver no GitHub

Mantenedores costumam responder em até 1 dia

Ninguém assumiu esta issue ainda.

Avaliação

Dificuldade
3/5
Tempo estimado
Meio dia
Facilidade para iniciantes
40/100
Tipo de issue
Funcionalidade
Clareza
Razoavelmente clara
Status de atividade
Ativa
Stack de tecnologia
go, typescript
Domínio
backend, frontend

Direção de pesquisa

Start with the native cap at apps/client-next/src/engine/foundation/gameplay/storage-room.ts (line 59) and find where SRO_RAISED_GOLD_CAPS sets the 1,000,000,000 limit for the dialog and the server check. Check GoldAmount in apps/server/internal/game/item/wire/itemmove.go, since the u32 bound caps what one move can carry. Done when the shard-chosen limit is applied to both the dialog and the server, and a test shows a deposit and withdrawal above 1,000,000,000 under the raised rule while the 100,000,000 cap still holds without it.

Escrita pelo modelo de indexação a partir do texto da issue.

Descrição

area: server enhancement priority: low

Player report BR-261112-0210-41A6 (in-game, 2026-11-12, thread 1570259499703345253 is the mall report; this is BR-261111-2056-1800, thread 1570180473551065089): gold cannot be deposited to or withdrawn from storage in amounts above the per-transaction cap; the player asks to move as much as they want in one transaction.

Not a bug: the cap is deliberate. The original caps one warehouse gold deposit at 100,000,000 (client 59A430, recorded at apps/client-next/src/engine/foundation/gameplay/storage-room.ts:59); this shard runs the port-only SRO_RAISED_GOLD_CAPS rule, which raises the dialog and the server check to 1,000,000,000 - the limit the player is hitting. The ask is to raise it further. One wire bound: a single gold move carries a u32 amount (apps/server/internal/game/item/wire/itemmove.go GoldAmount), so one transaction cannot exceed 4,294,967,295 without a wire change; the balance itself is 64-bit.

Done when: the raised-caps limit is a value the shard can choose (for example up to the wire bound), with the dialog and the server check agreeing, and a test pins a deposit and a withdrawal above 1,000,000,000 under the raised rule while the native 100,000,000 cap still applies without it.

Linguagem predominante
Go
Estrelas
97
Forks
61
Merge médio
4h 14min
PRs com merge (30d)
913

Preparar o ambiente

Primeiros passos

  1. Leia a issue inteira e depois o guia de contribuição do projeto.
  2. Comente na issue dizendo que vai assumir — evita que duas pessoas façam o mesmo trabalho.
  3. Faça um fork do repositório e trabalhe em uma branch.
  4. Abra um pull request que referencie o número da issue.

Mais de opensro-dev/opensro

Todas as issues de opensro-dev/opensro

Issues semelhantes

Mais issues de Go

Receba novas issues na sua caixa de entrada

Um resumo curto de issues do GitHub para quem está começando.