storage: let one gold deposit or withdrawal move more than the current per-transaction cap

Ouverte
#3,355 2 commentaires 0 réactions 0 personnes assignées Voir sur GitHub

Les mainteneurs répondent en général sous 1 jour

Personne n'a encore pris cette issue.

Évaluation

Difficulté
3/5
Temps estimé
Une demi-journée
Accessibilité débutants
40/100
Type d'issue
Fonctionnalité
Clarté
Plutôt claire
Activité
Active
Stack technique
go, typescript
Domaine
backend, frontend

Piste de recherche

Start with the native cap at apps/client-next/src/engine/foundation/gameplay/storage-room.ts (line 59) and find where SRO_RAISED_GOLD_CAPS sets the 1,000,000,000 limit for the dialog and the server check. Check GoldAmount in apps/server/internal/game/item/wire/itemmove.go, since the u32 bound caps what one move can carry. Done when the shard-chosen limit is applied to both the dialog and the server, and a test shows a deposit and withdrawal above 1,000,000,000 under the raised rule while the 100,000,000 cap still holds without it.

Rédigé par le modèle d'indexation à partir du texte de l'issue.

Description

area: server enhancement priority: low

Player report BR-261112-0210-41A6 (in-game, 2026-11-12, thread 1570259499703345253 is the mall report; this is BR-261111-2056-1800, thread 1570180473551065089): gold cannot be deposited to or withdrawn from storage in amounts above the per-transaction cap; the player asks to move as much as they want in one transaction.

Not a bug: the cap is deliberate. The original caps one warehouse gold deposit at 100,000,000 (client 59A430, recorded at apps/client-next/src/engine/foundation/gameplay/storage-room.ts:59); this shard runs the port-only SRO_RAISED_GOLD_CAPS rule, which raises the dialog and the server check to 1,000,000,000 - the limit the player is hitting. The ask is to raise it further. One wire bound: a single gold move carries a u32 amount (apps/server/internal/game/item/wire/itemmove.go GoldAmount), so one transaction cannot exceed 4,294,967,295 without a wire change; the balance itself is 64-bit.

Done when: the raised-caps limit is a value the shard can choose (for example up to the wire bound), with the dialog and the server check agreeing, and a test pins a deposit and a withdrawal above 1,000,000,000 under the raised rule while the native 100,000,000 cap still applies without it.

Langage dominant
Go
Étoiles
97
Forks
61
Merge moyen
4 h 14 min
PR mergées (30 j)
913

Préparer son environnement

Par où commencer

  1. Lisez l'issue en entier, puis le guide de contribution du projet.
  2. Signalez en commentaire que vous la prenez — cela évite que deux personnes fassent le même travail.
  3. Forkez le dépôt et travaillez sur une branche.
  4. Ouvrez une pull request qui référence le numéro de l'issue.

Autres issues de opensro-dev/opensro

Toutes les issues de opensro-dev/opensro

Issues similaires

Plus d'issues Go

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.