Re-evaluate need for the different "containered" builds that we do

Offen
  • Stimmt etwas nicht?
#4,543 4 Kommentare 0 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen

Maintainer antworten meist innerhalb von 2 Tagen

Dieses Issue hat noch niemand übernommen.

Bewertung

Schwierigkeit
5/5
Geschätzter Aufwand
Über eine Woche
Anfängerfreundlichkeit
25/100
Issue-Typ
Refactoring
Klarheit
Größtenteils klar
Aktivitätsstatus
Aktiv
Tech-Stack
github, node.js
Bereich
ci-cd, infrastructure

Rechercherichtung

Start by reviewing the listed containered build axes in the node-test-commit-linux-containered job, then compare how the Windows and ARM debug jobs run on PRs. Read the linked build issue about ARM container space for context. The issue is resolved when the discussion reaches a decision on which axes and debug builds to retain, move to daily runs, or change platforms.

Vom Indexierungsmodell aus dem Issue-Text verfasst.

Beschreibung

In node-test-commit-linux-containered we have the following build which are done on PRs (not necessatily all on each node version):

  • ubi81_sharedlibs_openssl111fips_x64
  • ubuntu2404_sharedlibs_debug_x64
  • ubuntu2404_sharedlibs_icu_x64
  • ubuntu2404_sharedlibs_openssl111_x64
  • ubuntu2404_sharedlibs_openssl30_x64
  • ubuntu2404_sharedlibs_openssl35_x64
  • ubuntu2404_sharedlibs_openssl40_x64
  • ubuntu2404_sharedlibs_shared_x64
  • ubuntu2404_sharedlibs_smallicu_x64
  • ubuntu2404_sharedlibs_withoutintl_x64
  • ubuntu2404_sharedlibs_withoutssl_x64
  • ubuntu2404_sharedlibs_zlib_x64

We should use this issue to discuss whether this is a suitable set of axis to build on.

A similar discussion should be had on the debug variants that we build for i.e. the node-compile-windows-debug and node-test-commit-arm-debug jobs. Do we still need those on every PR? It may be worth moving one or both of those to "daily" only. It's probably also worth trying to move the arm debug one back to x64 since that was mostly done for when we had the large equinix systems. The limited amount of space we have on the arm containered machines (I was looking at that recently in https://github.com/nodejs/build/issues/4534)

Two thoughts:

  • Is Ubuntu 24.04 the most suitable platform to do all of these on?
  • Could we have one "shared everything" axis which builds node as a shared library and also dynamically links to system shared libraries for SSL/ICU/zlib/anything else that we support on the system so we do them all together - and maybe have one older and one newer distribution to cover the ends of the spectrum (e.g. RHEL8 and Fedora latest? Those could be split over two architectures for additional coverage)
Vorherrschende Sprache
Jinja
Sterne
543
Forks
184
Ø Merge
4 T. 6 Std.
Gemergte PRs (30 T.)
8

Entwicklungsumgebung

Erste Schritte

  1. Lesen Sie das ganze Issue und danach den Beitragsleitfaden des Projekts.
  2. Schreiben Sie ins Issue, dass Sie es übernehmen — das erspart doppelte Arbeit.
  3. Forken Sie das Repository und arbeiten Sie in einem Branch.
  4. Öffnen Sie einen Pull Request, der die Issue-Nummer nennt.

Mehr aus nodejs/build

Alle Issues in nodejs/build

Ähnliche Issues

Weitere Issues zu DevOps

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.