Hacktoberfest 2026: as issues que os mantenedores marcaram para outubro, abertas e boas para iniciantes. Ver issues do Hacktoberfest

Re-evaluate need for the different "containered" builds that we do

Aberta
  • Algo errado?
#4,543 4 comentários 0 reações 0 responsáveis Ver no GitHub

Mantenedores costumam responder em até 1 dia

Ninguém assumiu esta issue ainda.

Avaliação

Dificuldade
5/5
Tempo estimado
Mais de uma semana
Facilidade para iniciantes
25/100
Tipo de issue
Refatoração
Clareza
Razoavelmente clara
Status de atividade
Ativa
Stack de tecnologia
github, node.js
Domínio
ci-cd, infrastructure

Direção de pesquisa

Start by reviewing the listed containered build axes in the node-test-commit-linux-containered job, then compare how the Windows and ARM debug jobs run on PRs. Read the linked build issue about ARM container space for context. The issue is resolved when the discussion reaches a decision on which axes and debug builds to retain, move to daily runs, or change platforms.

Escrita pelo modelo de indexação a partir do texto da issue.

Descrição

In node-test-commit-linux-containered we have the following build which are done on PRs (not necessatily all on each node version):

  • ubi81_sharedlibs_openssl111fips_x64
  • ubuntu2404_sharedlibs_debug_x64
  • ubuntu2404_sharedlibs_icu_x64
  • ubuntu2404_sharedlibs_openssl111_x64
  • ubuntu2404_sharedlibs_openssl30_x64
  • ubuntu2404_sharedlibs_openssl35_x64
  • ubuntu2404_sharedlibs_openssl40_x64
  • ubuntu2404_sharedlibs_shared_x64
  • ubuntu2404_sharedlibs_smallicu_x64
  • ubuntu2404_sharedlibs_withoutintl_x64
  • ubuntu2404_sharedlibs_withoutssl_x64
  • ubuntu2404_sharedlibs_zlib_x64

We should use this issue to discuss whether this is a suitable set of axis to build on.

A similar discussion should be had on the debug variants that we build for i.e. the node-compile-windows-debug and node-test-commit-arm-debug jobs. Do we still need those on every PR? It may be worth moving one or both of those to "daily" only. It's probably also worth trying to move the arm debug one back to x64 since that was mostly done for when we had the large equinix systems. The limited amount of space we have on the arm containered machines (I was looking at that recently in https://github.com/nodejs/build/issues/4534)

Two thoughts:

  • Is Ubuntu 24.04 the most suitable platform to do all of these on?
  • Could we have one "shared everything" axis which builds node as a shared library and also dynamically links to system shared libraries for SSL/ICU/zlib/anything else that we support on the system so we do them all together - and maybe have one older and one newer distribution to cover the ends of the spectrum (e.g. RHEL8 and Fedora latest? Those could be split over two architectures for additional coverage)
Linguagem predominante
Jinja
Estrelas
544
Forks
184
Merge médio
3d 12h
PRs com merge (30d)
7

Preparar o ambiente

Primeiros passos

  1. Leia a issue inteira e depois o guia de contribuição do projeto.
  2. Comente na issue dizendo que vai assumir — evita que duas pessoas façam o mesmo trabalho.
  3. Faça um fork do repositório e trabalhe em uma branch.
  4. Abra um pull request que referencie o número da issue.

Mais de nodejs/build

Todas as issues de nodejs/build

Issues semelhantes

Mais issues de DevOps

Receba novas issues na sua caixa de entrada

Um resumo curto de issues do GitHub para quem está começando.