Make the postinstall vscode-jsonrpc rewrite conditional, then lift the copilot-sdk cap

Offen
#2,415 0 Kommentare 0 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen

Maintainer antworten meist innerhalb von 1 Tag

Dieses Issue hat noch niemand übernommen.

Bewertung

Schwierigkeit
4/5
Geschätzter Aufwand
3-5 Tage
Anfängerfreundlichkeit
48/100
Issue-Typ
Bug
Klarheit
Größtenteils klar
Aktivitätsstatus
Aktiv
Tech-Stack
github, node.js, typescript
Bereich
cli, testing

Rechercherichtung

Start with packages/squad-cli/scripts/patch-esm-imports.mjs and trace which vscode-jsonrpc copy packages/squad-cli resolves from Copilot SDK's session.js; compare the 8.x and nested 10.x layouts. Read the doctor check in packages/squad-cli/src/cli/commands/doctor.ts and the runtime resolver hook in packages/squad-cli/src/cli-entry.ts. Add regression tests for both layouts, then lift the SDK cap and run test/cli-packaging-smoke.test.ts with copilot-sdk 1.0.29 or later.

Vom Indexierungsmodell aus dem Issue-Text verfasst.

Beschreibung

Follow-up to #2414, which caps @github/copilot-sdk below 1.0.29 as a mitigation.

Problem

packages/squad-cli/scripts/patch-esm-imports.mjs runs as the CLI postinstall and from squad upgrade (packages/squad-cli/src/cli/core/upgrade.ts:1113-1114). It patches unconditionally:

  • Layer 1 replaces the exports map of every vscode-jsonrpc copy in its search roots whose map lacks ./node.js. That includes valid 9.x and 10.x maps. It never sees the copy nested under @github/copilot-sdk/node_modules.
  • Layer 2 rewrites vscode-jsonrpc/node to vscode-jsonrpc/node.js in copilot-sdk's dist/session.js.

copilot-sdk 1.0.29 and later depend on vscode-jsonrpc 10, which exports ./node but not ./node.js, so the rewrite breaks the import with ERR_PACKAGE_PATH_NOT_EXPORTED.

Proposed fix

  • Rewrite only when the vscode-jsonrpc that session.js actually resolves to has no exports map (8.x). Otherwise leave the import alone. Consider undoing an earlier rewrite when the resolved copy doesn't export ./node.js.
  • Add an exports map only to copies that have none. Don't overwrite valid maps.
  • Apply the same condition to the squad doctor check (packages/squad-cli/src/cli/commands/doctor.ts:521-539), which currently tells users to run the postinstall whenever the import has no extension.
  • Review the runtime resolver hook in packages/squad-cli/src/cli-entry.ts:42-52.
  • Add regression tests for an 8.x layout and a nested 10.x layout. Then lift the cap in packages/squad-sdk/package.json and confirm test/cli-packaging-smoke.test.ts passes with copilot-sdk 1.0.29 or later.
Vorherrschende Sprache
TypeScript
Sterne
3.4k
Forks
516
Ø Merge
1 T. 15 Std.
Gemergte PRs (30 T.)
116

Entwicklungsumgebung

Erste Schritte

  1. Lesen Sie das ganze Issue und danach den Beitragsleitfaden des Projekts.
  2. Schreiben Sie ins Issue, dass Sie es übernehmen — das erspart doppelte Arbeit.
  3. Forken Sie das Repository und arbeiten Sie in einem Branch.
  4. Öffnen Sie einen Pull Request, der die Issue-Nummer nennt.

Mehr aus github/squad

Alle Issues in github/squad

Ähnliche Issues

Weitere Issues zu TypeScript

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.