Make the postinstall vscode-jsonrpc rewrite conditional, then lift the copilot-sdk cap

未關閉
#2,415 0 則留言 0 個 reaction 已指派 0 人 在 GitHub 檢視

維護者通常 1 天內回覆

還沒有人認領這個 Issue。

評估

難度
4/5
預估耗時
3-5 天
新手友好度
48/100
Issue 類型
缺陷
描述清晰度
基本清楚
活躍度
活躍
技術堆疊
github, node.js, typescript
領域
cli, testing

研究方向

Start with packages/squad-cli/scripts/patch-esm-imports.mjs and trace which vscode-jsonrpc copy packages/squad-cli resolves from Copilot SDK's session.js; compare the 8.x and nested 10.x layouts. Read the doctor check in packages/squad-cli/src/cli/commands/doctor.ts and the runtime resolver hook in packages/squad-cli/src/cli-entry.ts. Add regression tests for both layouts, then lift the SDK cap and run test/cli-packaging-smoke.test.ts with copilot-sdk 1.0.29 or later.

由索引模型根據 Issue 內容生成。

描述

Follow-up to #2414, which caps @github/copilot-sdk below 1.0.29 as a mitigation.

Problem

packages/squad-cli/scripts/patch-esm-imports.mjs runs as the CLI postinstall and from squad upgrade (packages/squad-cli/src/cli/core/upgrade.ts:1113-1114). It patches unconditionally:

  • Layer 1 replaces the exports map of every vscode-jsonrpc copy in its search roots whose map lacks ./node.js. That includes valid 9.x and 10.x maps. It never sees the copy nested under @github/copilot-sdk/node_modules.
  • Layer 2 rewrites vscode-jsonrpc/node to vscode-jsonrpc/node.js in copilot-sdk's dist/session.js.

copilot-sdk 1.0.29 and later depend on vscode-jsonrpc 10, which exports ./node but not ./node.js, so the rewrite breaks the import with ERR_PACKAGE_PATH_NOT_EXPORTED.

Proposed fix

  • Rewrite only when the vscode-jsonrpc that session.js actually resolves to has no exports map (8.x). Otherwise leave the import alone. Consider undoing an earlier rewrite when the resolved copy doesn't export ./node.js.
  • Add an exports map only to copies that have none. Don't overwrite valid maps.
  • Apply the same condition to the squad doctor check (packages/squad-cli/src/cli/commands/doctor.ts:521-539), which currently tells users to run the postinstall whenever the import has no extension.
  • Review the runtime resolver hook in packages/squad-cli/src/cli-entry.ts:42-52.
  • Add regression tests for an 8.x layout and a nested 10.x layout. Then lift the cap in packages/squad-sdk/package.json and confirm test/cli-packaging-smoke.test.ts passes with copilot-sdk 1.0.29 or later.
主要語言
TypeScript
星號
3.4k
分支
516
平均合併
1 天 15 小時
30 天內合併 PR
116

環境準備

從這裡開始

  1. 先讀完整個 Issue,再讀專案的貢獻指南。
  2. 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
  3. Fork 儲存庫,在一個分支上完成修改。
  4. 送出 Pull Request,並在描述裡引用這個 Issue 編號。

github/squad 的其他 Issue

查看 github/squad 的全部 Issue

相似的 Issue

更多 TypeScript Issue

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。