squad-sdk: spawnAgent ignores the persistent reasoning-effort and context-tier settings that its own commit documents

Offen Anfängerfreundlich
#2,521 0 Kommentare 0 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen

Maintainer antworten meist innerhalb von 1 Tag

Dieses Issue hat noch niemand übernommen.

Bewertung

Schwierigkeit
2/5
Geschätzter Aufwand
1-3 Stunden
Anfängerfreundlichkeit
82/100
Issue-Typ
Bug
Klarheit
Klar beschrieben
Aktivitätsstatus
Aktiv
Tech-Stack
typescript

Rechercherichtung

Lies packages/squad-sdk/src/agents/lifecycle.ts und die Resolver für persistente Einstellungen in packages/squad-sdk/src/config/models.ts. Untersuche anschließend die Spawn-Tests in test/lifecycle.test.ts, in denen die Konfiguration von createSession bereits erfasst wird. Ergänze Tests für defaultReasoningEffort und defaultContextTier; das Issue ist gelöst, wenn beide Werte die Session erreichen und die dokumentierte Priorität überprüft wurde.

Vom Indexierungsmodell aus dem Issue-Text verfasst.

Beschreibung

Summary

The two commits that threaded reasoning effort and context tier through agent spawning introduced
three things together:

  • the readers and the layered resolver in packages/squad-sdk/src/config/models.ts
    (readReasoningEffort, readAgentReasoningEffortOverrides, and the tier equivalents, 333 lines);
  • the template documentation that promises the layer -- .squad-templates/squad.agent.md, "1.
    Persistent Config: .squad/config.json ? agentReasoningEffortOverrides.{agentName}, then
    defaultReasoningEffort";
  • and the inline resolution in AgentLifecycleManager.spawnAgent that skips it:
const rawEffort = reasoningEffortOverride
  || agentConfig.resolvedReasoningEffort
  || undefined;

Environment

  • github/squad (the report was written against the bradygaster/squad fork, which carries the same
    commits; dev has the identical lines at packages/squad-sdk/src/agents/lifecycle.ts:328)
  • effort: 264b87612a -- feat(sdk): thread reasoningEffort through agent spawning pipeline (#1148),
    Co-authored-by: Copilot <[email protected]>
  • tier: f682ecb7ad -- feat(sdk,cli): thread contextTier through agent spawning pipeline (#1448),
    Co-authored-by: Copilot App <[email protected]>

Steps to reproduce

test/lifecycle.test.ts already wraps createSession and keeps every config in
sessionConfigs, and it already asserts on sessionConfigs[0].model for the persistent-config cases
(agentModelOverrides, defaultModel, 'auto'). The effort and the tier are the only two settings
that file never asserts on.

Take one of those cases, add defaultReasoningEffort and defaultContextTier to the
.squad/config.json it writes, and assert the same way:

expect(sessionConfigs[0]?.reasoningEffort).toBe('high');
expect(sessionConfigs[0]?.contextTier).toBe('long_context');

The capture itself needs no change -- it is the file's own.

Actual behavior

Running one of those persistent-config cases with defaultReasoningEffort: "high" and
defaultContextTier: "long_context" added to the config file, and no effort or tier anywhere else,
the object handed to createSession is:

{ "model": "charter-model", "systemMessage": { "content": "..." } }

reasoningEffort and contextTier are both absent (undefined), while model is the one the
charter names -- so the spawn ran, the config file was read, and only these two settings never reached
the session. Adding the assertion to that case fails:

AssertionError: expected undefined to be 'high' // Object.is equality
- Expected: "high"
+ Received:  undefined

Changing one input at a time, the same capture shows which layers do arrive:

variant .squad/config.json charter spawn option reasoningEffort in the session
A defaultReasoningEffort: high none none undefined
B none **Reasoning Effort:** medium none "medium"
C defaultReasoningEffort: high none reasoningEffortOverride: low "low"
D defaultReasoningEffort: high **Reasoning Effort:** medium none "medium"

A is the documented layer 1 and the only one that produces nothing. D shows the persistent value
losing to a charter value the documentation ranks below it. The tier behaves the same way: a charter
naming **Context Tier:** long_context reaches the session, defaultContextTier does not.

Expected behavior

{ "model": "claude-sonnet-5.5", "reasoningEffort": "high", "contextTier": "long_context" }

Suggested fix

The resolver the same commits added already implements the documented order; call it instead of
resolving inline:

const rawEffort = resolveReasoningEffort({
  agentName, squadDir,
  spawnOverride: reasoningEffortOverride,
  charterPreference: agentConfig.resolvedReasoningEffort,
});

Failing that, add the two persistent lookups in front of the charter value.

Vorherrschende Sprache
TypeScript
Sterne
3.4k
Forks
516
Ø Merge
1 T. 15 Std.
Gemergte PRs (30 T.)
116

Entwicklungsumgebung

Erste Schritte

  1. Lesen Sie das ganze Issue und danach den Beitragsleitfaden des Projekts.
  2. Schreiben Sie ins Issue, dass Sie es übernehmen — das erspart doppelte Arbeit.
  3. Forken Sie das Repository und arbeiten Sie in einem Branch.
  4. Öffnen Sie einen Pull Request, der die Issue-Nummer nennt.

Mehr aus github/squad

Alle Issues in github/squad

Ähnliche Issues

Weitere Issues zu TypeScript

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.