Feedback tool captures reports about other servers' tools

Offen
  • Stimmt etwas nicht?
#2,255 2 Kommentare 0 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen

Maintainer antworten meist innerhalb von 1 Tag

Dieses Issue hat noch niemand übernommen.

Bewertung

Schwierigkeit
3/5
Geschätzter Aufwand
1-2 Tage
Anfängerfreundlichkeit
35/100
Issue-Typ
Bug
Klarheit
Größtenteils klar
Aktivitätsstatus
Aktiv
Tech-Stack
typescript
Bereich
devtools

Rechercherichtung

Start in packages/mcp-core/src/tools/catalog/submit-feedback-to-sentry-team.ts, where toolName is taken as free text (around lines 103-108) and copied into the message and the feedback.tool tag (around lines 128 and 143). Check packages/mcp-core/src/toolDefinitions.json for the catalog of valid Sentry MCP tool names. Done means a value that names no Sentry tool is handled, and the issue leaves open whether to reject it or only tighten the description. That decision is not settled in the thread, so confirm it with maintainers before coding.

Vom Indexierungsmodell aus dem Issue-Text verfasst.

Beschreibung

submit_feedback_to_sentry_team keeps capturing reports about tools that belong to other MCP servers or to the client, which the Sentry MCP maintainers can't act on. getsentry/toolkit#2197 limited the description to Sentry MCP problems, but three of these reports arrived after it was deployed.

  • Reports in mcp-server over the last 14 days that are about a non-Sentry tool:
    • MCP-SERVER-GQ1 (2026-11-13 21:16 UTC): toolName=GitHub_-_Read_File1, a GitHub server's read-file tool returning empty output for large directories.
    • MCP-SERVER-GQ0 (2026-11-13 21:15 UTC, same caller): toolName=GitHub_-_Search_Code1, a GitHub code search tool returning no results.
    • MCP-SERVER-GPY (2026-11-13 18:31 UTC): toolName=review_scan. The description itself says it's feedback for a code-review automation, "not Sentry MCP itself; no better feedback channel was available in this session."
    • MCP-SERVER-GN5 (11-10), MCP-SERVER-GMD (11-07), MCP-SERVER-GKH (11-05): no toolName. Each one is about a client-side apply_code_edit tool failing. The client looks the same as GQ0/GQ1.
  • For GQ0/GQ1, the caller's spans (matched by client IP, since no mcp.session.id was recorded and the feedback trace wasn't sampled) show only Sentry tool calls: find_projects (21:14:05), search_issues (21:14:12), search_errors (21:14:30), all ok, then submit_feedback_to_sentry_team (21:15:36). No Sentry tool failed. The failing tools are not in the Sentry MCP catalog (packages/mcp-core/src/toolDefinitions.json).
  • The server takes toolName as free text (packages/mcp-core/src/tools/catalog/submit-feedback-to-sentry-team.ts:103-108) and copies it into the message and the feedback.tool tag (:128, :143) without checking it against the catalog. So a value that names no Sentry MCP tool is still captured.
  • The description already says "Report a Sentry MCP tool that failed" and "Call it only when a Sentry MCP tool was missing, failed, or got in the way" (:64, :72). Agents that have no feedback channel for their other tools are using this one anyway. GPY says so directly.
  • Not verified: what the client tells its agents about feedback. Its instructions don't show up in our traces.

Refs getsentry/toolkit#2169, getsentry/toolkit#2197

via Sentry.

--

View Session [Sentry]

Vorherrschende Sprache
TypeScript
Sterne
961
Forks
179
Ø Merge
15 Std. 33 Min.
Gemergte PRs (30 T.)
476

Entwicklungsumgebung

Dieses Projekt bietet weder Dev-Container noch Dockerfile noch Beitragsleitfaden – die Einrichtung liegt bei Ihnen. Beginnen Sie mit der README; die allgemeinen Schritte stehen in unserem Leitfaden für den ersten Beitrag.

Erste Schritte

  1. Lesen Sie das ganze Issue und danach den Beitragsleitfaden des Projekts.
  2. Schreiben Sie ins Issue, dass Sie es übernehmen — das erspart doppelte Arbeit.
  3. Forken Sie das Repository und arbeiten Sie in einem Branch.
  4. Öffnen Sie einen Pull Request, der die Issue-Nummer nennt.

Mehr aus getsentry/toolkit

Alle Issues in getsentry/toolkit

Ähnliche Issues

Weitere Issues zu TypeScript

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.