Preserve imported CV captured by code reference across namespace cleanup

Offen
#2,130 0 Kommentare 0 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen

Maintainer antworten meist innerhalb von 1 Tag

Dieses Issue hat noch niemand übernommen.

Bewertung

Schwierigkeit
4/5
Geschätzter Aufwand
3-5 Tage
Anfängerfreundlichkeit
48/100
Issue-Typ
Bug
Klarheit
Klar beschrieben
Aktivitätsstatus
Aktiv
Tech-Stack
java, perl
Bereich
backend, testing

Rechercherichtung

Start by reading EmitSubroutine and GlobalVariable.getGlobalCodeRefForNamedReference, then trace how the interpreter handles the same captured &name reference after namespace::clean removes the package symbol. Add a focused regression test for capture, cleanup, and invocation; check it under standard Perl and on both PerlOnJava backends, while confirming the direct-call behavior covered by PR #694 remains intact.

Vom Indexierungsmodell aus dem Issue-Text verfasst.

Beschreibung

area:parser area:runtime bug

Summary

Subclass-Of 0.009 fails when its Moo attribute helper captures the imported has function with &has, runs namespace::clean, and invokes the captured code reference. Perl 5 preserves the imported CV even after the package stash entry is cleaned. PerlOnJava instead calls an undefined stub.

This is reproducible on both PerlOnJava execution backends and affects the upstream t/03moo.t test.

Reproducer

my $has = eval q{
    package DirectMooEval;
    use Moo;
    my $has = \&has;
    use namespace::clean;
    return $has;
};
die $@ unless $has;
$has->("foo", is => "ro");

Expected: the captured CV remains callable and the attribute is installed.

Actual on PerlOnJava: Undefined subroutine &DirectMooEval::has called.

System Perl 5.34.1 passes this focused reproducer. The archived CPAN oracle ran Perl 5.42.2 and passed the full Subclass-Of suite.

CPAN evidence

  • Distribution: Subclass-Of 0.009
  • Run: 20261119-133823-51077
  • Standard Perl: all available upstream tests pass (80 tests; Mouse-dependent test skipped)
  • PerlOnJava: 61/63 tests; failures in t/03moo.t, t/07warnings.t, and t/08lazy.t
  • The focused t/03moo.t failure was reproduced on both JVM and interpreter with PerlOnJava commit aa51fb913, OpenJDK 24.0.2, macOS arm64.

The actionable scope here is the imported CV capture failure in t/03moo.t. The other failing files are recorded as run evidence and have not been established as the same defect.

Root-cause evidence

The upstream sequence captures the imported function before use namespace::clean removes its package entry. A code reference created before that cleanup must continue to point to the imported CV.

PerlOnJava’s JVM emitter currently resolves a named code reference through GlobalVariable.getGlobalCodeRefForNamedReference when the expression runs (EmitSubroutine). The interpreter path also fails to retain a callable CV through the same cleanup sequence. This indicates a mismatch in when &name binds an imported CV and how that binding survives package-stash cleanup; it is not simply a missing Moo dependency or an import that never ran.

PR #694 covers imported CVs for direct calls across stash cleanup, but not a captured &name reference invoked after cleanup. Closed issue #1548 covers caller metadata and is unrelated to this binding behavior.

Acceptance

  • Add a focused project regression test for capturing an imported CV, cleaning its package symbol, and then calling the saved reference.
  • Validate the behavior under standard Perl.
  • Make the regression pass on both JVM and interpreter backends.
  • Preserve the direct-call behavior covered by PR #694.
Vorherrschende Sprache
Perl
Sterne
67
Forks
8
Ø Merge
5 Std. 12 Min.
Gemergte PRs (30 T.)
131

Entwicklungsumgebung

Erste Schritte

  1. Lesen Sie das ganze Issue und danach den Beitragsleitfaden des Projekts.
  2. Schreiben Sie ins Issue, dass Sie es übernehmen — das erspart doppelte Arbeit.
  3. Forken Sie das Repository und arbeiten Sie in einem Branch.
  4. Öffnen Sie einen Pull Request, der die Issue-Nummer nennt.

Mehr aus fglock/PerlOnJava

Alle Issues in fglock/PerlOnJava

Ähnliche Issues

Weitere Issues zu Perl

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.