Preserve imported CV captured by code reference across namespace cleanup
メンテナーはふだん 1 日以内に返信
まだ誰も着手していません。
評価
- 難易度
- 4/5
- 見積もり時間
- 3〜5日
- 初心者へのやさしさ
- 48/100
調査の方向性
Start by reading EmitSubroutine and GlobalVariable.getGlobalCodeRefForNamedReference, then trace how the interpreter handles the same captured &name reference after namespace::clean removes the package symbol. Add a focused regression test for capture, cleanup, and invocation; check it under standard Perl and on both PerlOnJava backends, while confirming the direct-call behavior covered by PR #694 remains intact.
索引モデルが issue の本文から書いたものです。
説明
Summary
Subclass-Of 0.009 fails when its Moo attribute helper captures the imported has function with &has, runs namespace::clean, and invokes the captured code reference. Perl 5 preserves the imported CV even after the package stash entry is cleaned. PerlOnJava instead calls an undefined stub.
This is reproducible on both PerlOnJava execution backends and affects the upstream t/03moo.t test.
Reproducer
my $has = eval q{
package DirectMooEval;
use Moo;
my $has = \&has;
use namespace::clean;
return $has;
};
die $@ unless $has;
$has->("foo", is => "ro");
Expected: the captured CV remains callable and the attribute is installed.
Actual on PerlOnJava: Undefined subroutine &DirectMooEval::has called.
System Perl 5.34.1 passes this focused reproducer. The archived CPAN oracle ran Perl 5.42.2 and passed the full Subclass-Of suite.
CPAN evidence
- Distribution: Subclass-Of 0.009
- Run: 20261119-133823-51077
- Standard Perl: all available upstream tests pass (80 tests; Mouse-dependent test skipped)
- PerlOnJava: 61/63 tests; failures in t/03moo.t, t/07warnings.t, and t/08lazy.t
- The focused t/03moo.t failure was reproduced on both JVM and interpreter with PerlOnJava commit aa51fb913, OpenJDK 24.0.2, macOS arm64.
The actionable scope here is the imported CV capture failure in t/03moo.t. The other failing files are recorded as run evidence and have not been established as the same defect.
Root-cause evidence
The upstream sequence captures the imported function before use namespace::clean removes its package entry. A code reference created before that cleanup must continue to point to the imported CV.
PerlOnJava’s JVM emitter currently resolves a named code reference through GlobalVariable.getGlobalCodeRefForNamedReference when the expression runs (EmitSubroutine). The interpreter path also fails to retain a callable CV through the same cleanup sequence. This indicates a mismatch in when &name binds an imported CV and how that binding survives package-stash cleanup; it is not simply a missing Moo dependency or an import that never ran.
PR #694 covers imported CVs for direct calls across stash cleanup, but not a captured &name reference invoked after cleanup. Closed issue #1548 covers caller metadata and is unrelated to this binding behavior.
Acceptance
- Add a focused project regression test for capturing an imported CV, cleaning its package symbol, and then calling the saved reference.
- Validate the behavior under standard Perl.
- Make the regression pass on both JVM and interpreter backends.
- Preserve the direct-call behavior covered by PR #694.
- 主要言語
- Perl
- スター
- 67
- フォーク
- 8
- 平均マージ
- 5時間 12分
- マージ済み PR(30日)
- 131
環境構築
- Dockerfile または Docker Compose ファイルあり
- プルリクエストのテンプレートなし
- コントリビューションガイドを読む
はじめの一歩
- issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
- 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
- リポジトリをフォークし、ブランチを切って変更します。
- issue 番号を参照したプルリクエストを送ります。
fglock/PerlOnJava のほかの issue
-
area:cpan-port bug
難易度 2/5 1〜3時間 初心者へのやさしさ 70/100
fglock/PerlOnJava#2153 ·
メンテナーはふだん 1 日以内に返信
-
area:cpan-port area:parser bug
難易度 2/5 1〜3時間 初心者へのやさしさ 68/100
fglock/PerlOnJava#2137 ·
メンテナーはふだん 1 日以内に返信
-
area:backend area:cpan-port area:runtime bug
難易度 2/5 1〜3時間 初心者へのやさしさ 76/100
fglock/PerlOnJava#2071 ·
メンテナーはふだん 1 日以内に返信
-
area:runtime documentation enhancement
難易度 2/5 1〜3時間 初心者へのやさしさ 72/100
fglock/PerlOnJava#1579 ·
メンテナーはふだん 1 日以内に返信
-
area:cpan-port bug
難易度 3/5 1〜2日 初心者へのやさしさ 62/100
fglock/PerlOnJava#2157 ·
メンテナーはふだん 1 日以内に返信
fglock/PerlOnJava の issue をすべて見る
似ている issue
-
Dev-output directory preparation accepts file-valued lib/include paths and fails on dangling linksオープンteam-cli
難易度 2/5 1〜3時間 初心者へのやさしさ 70/100
メンテナーはふだん 2 日以内に返信
-
難易度 2/5 1〜3時間 初心者へのやさしさ 66/100
-
難易度 1/5 1時間未満 初心者へのやさしさ 93/100
メンテナーはふだん 1 日以内に返信
-
難易度 2/5 1〜3時間 初心者へのやさしさ 73/100
inverse-inc/packetfence#9728 ·
メンテナーはふだん 1 日以内に返信
-
fix(char-create): show the real reason a character is refused対応中かも @baphomello が 1 日前に担当しました。 オープン
難易度 2/5 1〜3時間 初心者へのやさしさ 84/100
メンテナーはふだん 1 日以内に返信