Preserve imported CV captured by code reference across namespace cleanup
Los mantenedores suelen responder en 1 día
Nadie ha tomado este issue todavía.
Evaluación
- Dificultad
- 4/5
- Tiempo estimado
- 3-5 días
- Aptitud para principiantes
- 48/100
Línea de trabajo
Start by reading EmitSubroutine and GlobalVariable.getGlobalCodeRefForNamedReference, then trace how the interpreter handles the same captured &name reference after namespace::clean removes the package symbol. Add a focused regression test for capture, cleanup, and invocation; check it under standard Perl and on both PerlOnJava backends, while confirming the direct-call behavior covered by PR #694 remains intact.
Escrito por el modelo de indexación a partir del texto del issue.
Descripción
Summary
Subclass-Of 0.009 fails when its Moo attribute helper captures the imported has function with &has, runs namespace::clean, and invokes the captured code reference. Perl 5 preserves the imported CV even after the package stash entry is cleaned. PerlOnJava instead calls an undefined stub.
This is reproducible on both PerlOnJava execution backends and affects the upstream t/03moo.t test.
Reproducer
my $has = eval q{
package DirectMooEval;
use Moo;
my $has = \&has;
use namespace::clean;
return $has;
};
die $@ unless $has;
$has->("foo", is => "ro");
Expected: the captured CV remains callable and the attribute is installed.
Actual on PerlOnJava: Undefined subroutine &DirectMooEval::has called.
System Perl 5.34.1 passes this focused reproducer. The archived CPAN oracle ran Perl 5.42.2 and passed the full Subclass-Of suite.
CPAN evidence
- Distribution: Subclass-Of 0.009
- Run: 20261119-133823-51077
- Standard Perl: all available upstream tests pass (80 tests; Mouse-dependent test skipped)
- PerlOnJava: 61/63 tests; failures in t/03moo.t, t/07warnings.t, and t/08lazy.t
- The focused t/03moo.t failure was reproduced on both JVM and interpreter with PerlOnJava commit aa51fb913, OpenJDK 24.0.2, macOS arm64.
The actionable scope here is the imported CV capture failure in t/03moo.t. The other failing files are recorded as run evidence and have not been established as the same defect.
Root-cause evidence
The upstream sequence captures the imported function before use namespace::clean removes its package entry. A code reference created before that cleanup must continue to point to the imported CV.
PerlOnJava’s JVM emitter currently resolves a named code reference through GlobalVariable.getGlobalCodeRefForNamedReference when the expression runs (EmitSubroutine). The interpreter path also fails to retain a callable CV through the same cleanup sequence. This indicates a mismatch in when &name binds an imported CV and how that binding survives package-stash cleanup; it is not simply a missing Moo dependency or an import that never ran.
PR #694 covers imported CVs for direct calls across stash cleanup, but not a captured &name reference invoked after cleanup. Closed issue #1548 covers caller metadata and is unrelated to this binding behavior.
Acceptance
- Add a focused project regression test for capturing an imported CV, cleaning its package symbol, and then calling the saved reference.
- Validate the behavior under standard Perl.
- Make the regression pass on both JVM and interpreter backends.
- Preserve the direct-call behavior covered by PR #694.
- Lenguaje dominante
- Perl
- Estrellas
- 67
- Forks
- 8
- Merge medio
- 5 h 12 min
- PR fusionados (30 d)
- 131
Preparar el entorno
- Incluye un Dockerfile o un archivo de Docker Compose
- Sin plantilla de pull request
- Leer la guía de contribución
Primeros pasos
- Lee el issue completo y luego la guía de contribución del proyecto.
- Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
- Haz un fork del repositorio y trabaja en una rama.
- Abre un pull request que haga referencia al número del issue.
Más de fglock/PerlOnJava
-
area:cpan-port bug
Dificultad 2/5 1-3 horas Aptitud para principiantes 70/100
fglock/PerlOnJava#2153 ·
Los mantenedores suelen responder en 1 día
-
area:cpan-port area:parser bug
Dificultad 2/5 1-3 horas Aptitud para principiantes 68/100
fglock/PerlOnJava#2137 ·
Los mantenedores suelen responder en 1 día
-
area:backend area:cpan-port area:runtime bug
Dificultad 2/5 1-3 horas Aptitud para principiantes 76/100
fglock/PerlOnJava#2071 ·
Los mantenedores suelen responder en 1 día
-
area:runtime documentation enhancement
Dificultad 2/5 1-3 horas Aptitud para principiantes 72/100
fglock/PerlOnJava#1579 ·
Los mantenedores suelen responder en 1 día
-
area:cpan-port bug
Dificultad 3/5 1-2 días Aptitud para principiantes 62/100
fglock/PerlOnJava#2157 ·
Los mantenedores suelen responder en 1 día
Todos los issues de fglock/PerlOnJava
Issues similares
-
Dev-output directory preparation accepts file-valued lib/include paths and fails on dangling linksAbiertoteam-cli
Dificultad 2/5 1-3 horas Aptitud para principiantes 70/100
Los mantenedores suelen responder en 2 días
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 66/100
-
Dificultad 1/5 Menos de una hora Aptitud para principiantes 93/100
Los mantenedores suelen responder en 1 día
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 73/100
inverse-inc/packetfence#9728 ·
Los mantenedores suelen responder en 1 día
-
fix(char-create): show the real reason a character is refusedPosiblemente ocupada @baphomello la tomó hace 1 día. Abierto
Dificultad 2/5 1-3 horas Aptitud para principiantes 84/100
Los mantenedores suelen responder en 1 día