Preserve imported CV captured by code reference across namespace cleanup

Abierto
#2,130 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
4/5
Tiempo estimado
3-5 días
Aptitud para principiantes
48/100
Tipo de issue
Error
Claridad
Bien especificado
Estado de actividad
Activo
Stack tecnológico
java, perl
Área
backend, testing

Línea de trabajo

Start by reading EmitSubroutine and GlobalVariable.getGlobalCodeRefForNamedReference, then trace how the interpreter handles the same captured &name reference after namespace::clean removes the package symbol. Add a focused regression test for capture, cleanup, and invocation; check it under standard Perl and on both PerlOnJava backends, while confirming the direct-call behavior covered by PR #694 remains intact.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

area:parser area:runtime bug

Summary

Subclass-Of 0.009 fails when its Moo attribute helper captures the imported has function with &has, runs namespace::clean, and invokes the captured code reference. Perl 5 preserves the imported CV even after the package stash entry is cleaned. PerlOnJava instead calls an undefined stub.

This is reproducible on both PerlOnJava execution backends and affects the upstream t/03moo.t test.

Reproducer

my $has = eval q{
    package DirectMooEval;
    use Moo;
    my $has = \&has;
    use namespace::clean;
    return $has;
};
die $@ unless $has;
$has->("foo", is => "ro");

Expected: the captured CV remains callable and the attribute is installed.

Actual on PerlOnJava: Undefined subroutine &DirectMooEval::has called.

System Perl 5.34.1 passes this focused reproducer. The archived CPAN oracle ran Perl 5.42.2 and passed the full Subclass-Of suite.

CPAN evidence

  • Distribution: Subclass-Of 0.009
  • Run: 20261119-133823-51077
  • Standard Perl: all available upstream tests pass (80 tests; Mouse-dependent test skipped)
  • PerlOnJava: 61/63 tests; failures in t/03moo.t, t/07warnings.t, and t/08lazy.t
  • The focused t/03moo.t failure was reproduced on both JVM and interpreter with PerlOnJava commit aa51fb913, OpenJDK 24.0.2, macOS arm64.

The actionable scope here is the imported CV capture failure in t/03moo.t. The other failing files are recorded as run evidence and have not been established as the same defect.

Root-cause evidence

The upstream sequence captures the imported function before use namespace::clean removes its package entry. A code reference created before that cleanup must continue to point to the imported CV.

PerlOnJava’s JVM emitter currently resolves a named code reference through GlobalVariable.getGlobalCodeRefForNamedReference when the expression runs (EmitSubroutine). The interpreter path also fails to retain a callable CV through the same cleanup sequence. This indicates a mismatch in when &name binds an imported CV and how that binding survives package-stash cleanup; it is not simply a missing Moo dependency or an import that never ran.

PR #694 covers imported CVs for direct calls across stash cleanup, but not a captured &name reference invoked after cleanup. Closed issue #1548 covers caller metadata and is unrelated to this binding behavior.

Acceptance

  • Add a focused project regression test for capturing an imported CV, cleaning its package symbol, and then calling the saved reference.
  • Validate the behavior under standard Perl.
  • Make the regression pass on both JVM and interpreter backends.
  • Preserve the direct-call behavior covered by PR #694.
Lenguaje dominante
Perl
Estrellas
67
Forks
8
Merge medio
5 h 12 min
PR fusionados (30 d)
131

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de fglock/PerlOnJava

Todos los issues de fglock/PerlOnJava

Issues similares

Más issues de Perl

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.