perf: split BytecodeInterpreter.execute for default C2 compilation
Maintainer antworten meist innerhalb von 1 Tag
Dieses Issue hat noch niemand übernommen.
Bewertung
- Schwierigkeit
- 5/5
- Geschätzter Aufwand
- Über eine Woche
- Anfängerfreundlichkeit
- 25/100
- Issue-Typ
- Refactoring
- Klarheit
- Klar beschrieben
- Aktivitätsstatus
- Aktiv
- Tech-Stack
- java
- Bereich
- backend, performance
Rechercherichtung
Start by reading BytecodeInterpreter.execute(SuspendedInterpreterFrame) and the profiling skill at .agents/skills/profile-perlonjava/SKILL.md; use dev/bench/benchmark_eval_string.pl to reproduce the eval STRING workload. Split the dispatch path while preserving opcode behavior and JVM/interpreter parity, then check HotSpot diagnostics, project tests, and the make gate. Compare randomized paired runs against the exact parent and check representative workloads and startup cost; done means default flags produce effective C2 compilation with a measured improvement and no material regression.
Vom Indexierungsmodell aus dem Issue-Text verfasst.
Beschreibung
Summary
Split BytecodeInterpreter.execute(SuspendedInterpreterFrame) into smaller dispatch/handler methods so HotSpot's default C2 policy can optimize the eval STRING interpreter path without globally enabling compilation of huge methods.
This is follow-up work to eval performance investigations on master. PR #2059 contains allocation and frame-pooling changes, but its performance effect was small and did not address the dispatch method's JIT compilation limit.
Evidence
On master commit 3e725aa6e1 (Temurin 24.0.2, Apple Silicon), async-profiler sampling of dev/bench/benchmark_eval_string.pl showed BytecodeInterpreter.execute as the largest CPU leaf (199 of 1,694 samples, C1), followed by StatementResolver.parseStatement (59) and CompileAssignment.compileAssignmentOperator (48).
HotSpot compilation diagnostics report the private execute(SuspendedInterpreterFrame) method at 23,790 bytecodes. The default DontCompileHugeMethods policy prevents C2 from optimizing this hot dispatch path; the log also reports it as too large to inline.
As a diagnostic, disabling that policy with -XX:-DontCompileHugeMethods caused the 23,790-byte method to reach C2 level 4. Five randomized default/flag pairs on the same master JAR measured:
| Default | C2 enabled | Speedup |
|---|---|---|
| 52.4k/s | 102.7k/s | 1.96x |
| 60.7k/s | 98.1k/s | 1.62x |
| 65.7k/s | 98.3k/s | 1.50x |
| 71.2k/s | 106.9k/s | 1.50x |
| 73.2k/s | 114.3k/s | 1.56x |
Each run executes one million iterations of dev/bench/benchmark_eval_string.pl. The geometric mean paired gain is about 1.60x. Host load caused variance in both modes; all five pairs favored C2.
Goal
Reduce the dispatch method's bytecode size enough that the normal JVM policy compiles its hot path effectively. Prefer extracting cold opcode families and keeping common eval opcodes on a direct, JIT-friendly path. Keep opcode semantics, exception behavior, interpreter state, and JVM/interpreter parity unchanged.
The global -XX:-DontCompileHugeMethods flag is a measured interim option, but this issue is to determine whether a source-level split can get the same or better result without changing HotSpot's huge-method policy for every method in the process.
Acceptance
- HotSpot diagnostics on supported Java versions show the refactored hot interpreter path gets C2 compilation with default JVM flags.
- Standard Perl behavior and project-owned tests cover affected opcode families; JVM and interpreter backends remain compatible.
- Run the repository
makegate on the immutable candidate. - Compare default-flag performance against the exact parent using randomized paired eval STRING benchmark runs with operation counts/checksums; retain the split only when the paired interval shows a real improvement.
- Check representative non-eval workloads and startup/compilation cost so a faster eval benchmark does not hide a material regression elsewhere.
Related
- PR #2059: https://github.com/fglock/PerlOnJava/pull/2059
- Performance goal #1196: https://github.com/fglock/PerlOnJava/issues/1196
dev/bench/benchmark_eval_string.pl.agents/skills/profile-perlonjava/SKILL.md
- Vorherrschende Sprache
- Perl
- Sterne
- 67
- Forks
- 8
- Ø Merge
- 5 Std. 12 Min.
- Gemergte PRs (30 T.)
- 131
Entwicklungsumgebung
- Enthält ein Dockerfile oder eine Docker-Compose-Datei
- Keine Pull-Request-Vorlage
- Beitragsleitfaden lesen
Erste Schritte
- Lesen Sie das ganze Issue und danach den Beitragsleitfaden des Projekts.
- Schreiben Sie ins Issue, dass Sie es übernehmen — das erspart doppelte Arbeit.
- Forken Sie das Repository und arbeiten Sie in einem Branch.
- Öffnen Sie einen Pull Request, der die Issue-Nummer nennt.
Mehr aus fglock/PerlOnJava
-
area:cpan-port bug
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 70/100
fglock/PerlOnJava#2153 ·
Maintainer antworten meist innerhalb von 1 Tag
-
area:cpan-port area:parser bug
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 68/100
fglock/PerlOnJava#2137 ·
Maintainer antworten meist innerhalb von 1 Tag
-
area:backend area:cpan-port area:runtime bug
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 76/100
fglock/PerlOnJava#2071 ·
Maintainer antworten meist innerhalb von 1 Tag
-
area:runtime documentation enhancement
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 72/100
fglock/PerlOnJava#1579 ·
Maintainer antworten meist innerhalb von 1 Tag
-
area:cpan-port bug
Schwierigkeit 3/5 1-2 Tage Anfängerfreundlichkeit 62/100
fglock/PerlOnJava#2157 ·
Maintainer antworten meist innerhalb von 1 Tag
Alle Issues in fglock/PerlOnJava
Ähnliche Issues
-
Dev-output directory preparation accepts file-valued lib/include paths and fails on dangling linksOffenteam-cli
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 70/100
Maintainer antworten meist innerhalb von 2 Tagen
-
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 66/100
-
Schwierigkeit 1/5 Unter einer Stunde Anfängerfreundlichkeit 93/100
Maintainer antworten meist innerhalb von 1 Tag
-
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 73/100
inverse-inc/packetfence#9728 ·
Maintainer antworten meist innerhalb von 1 Tag
-
fix(char-create): show the real reason a character is refusedEvtl. vergeben @baphomello hat das vor 1 Tag übernommen. Offen
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 84/100
Maintainer antworten meist innerhalb von 1 Tag