perf: split BytecodeInterpreter.execute for default C2 compilation
Los mantenedores suelen responder en 1 día
Nadie ha tomado este issue todavía.
Evaluación
- Dificultad
- 5/5
- Tiempo estimado
- Más de una semana
- Aptitud para principiantes
- 25/100
- Tipo de issue
- Refactorización
- Claridad
- Bien especificado
- Estado de actividad
- Activo
- Stack tecnológico
- java
- Área
- backend, performance
Línea de trabajo
Start by reading BytecodeInterpreter.execute(SuspendedInterpreterFrame) and the profiling skill at .agents/skills/profile-perlonjava/SKILL.md; use dev/bench/benchmark_eval_string.pl to reproduce the eval STRING workload. Split the dispatch path while preserving opcode behavior and JVM/interpreter parity, then check HotSpot diagnostics, project tests, and the make gate. Compare randomized paired runs against the exact parent and check representative workloads and startup cost; done means default flags produce effective C2 compilation with a measured improvement and no material regression.
Escrito por el modelo de indexación a partir del texto del issue.
Descripción
Summary
Split BytecodeInterpreter.execute(SuspendedInterpreterFrame) into smaller dispatch/handler methods so HotSpot's default C2 policy can optimize the eval STRING interpreter path without globally enabling compilation of huge methods.
This is follow-up work to eval performance investigations on master. PR #2059 contains allocation and frame-pooling changes, but its performance effect was small and did not address the dispatch method's JIT compilation limit.
Evidence
On master commit 3e725aa6e1 (Temurin 24.0.2, Apple Silicon), async-profiler sampling of dev/bench/benchmark_eval_string.pl showed BytecodeInterpreter.execute as the largest CPU leaf (199 of 1,694 samples, C1), followed by StatementResolver.parseStatement (59) and CompileAssignment.compileAssignmentOperator (48).
HotSpot compilation diagnostics report the private execute(SuspendedInterpreterFrame) method at 23,790 bytecodes. The default DontCompileHugeMethods policy prevents C2 from optimizing this hot dispatch path; the log also reports it as too large to inline.
As a diagnostic, disabling that policy with -XX:-DontCompileHugeMethods caused the 23,790-byte method to reach C2 level 4. Five randomized default/flag pairs on the same master JAR measured:
| Default | C2 enabled | Speedup |
|---|---|---|
| 52.4k/s | 102.7k/s | 1.96x |
| 60.7k/s | 98.1k/s | 1.62x |
| 65.7k/s | 98.3k/s | 1.50x |
| 71.2k/s | 106.9k/s | 1.50x |
| 73.2k/s | 114.3k/s | 1.56x |
Each run executes one million iterations of dev/bench/benchmark_eval_string.pl. The geometric mean paired gain is about 1.60x. Host load caused variance in both modes; all five pairs favored C2.
Goal
Reduce the dispatch method's bytecode size enough that the normal JVM policy compiles its hot path effectively. Prefer extracting cold opcode families and keeping common eval opcodes on a direct, JIT-friendly path. Keep opcode semantics, exception behavior, interpreter state, and JVM/interpreter parity unchanged.
The global -XX:-DontCompileHugeMethods flag is a measured interim option, but this issue is to determine whether a source-level split can get the same or better result without changing HotSpot's huge-method policy for every method in the process.
Acceptance
- HotSpot diagnostics on supported Java versions show the refactored hot interpreter path gets C2 compilation with default JVM flags.
- Standard Perl behavior and project-owned tests cover affected opcode families; JVM and interpreter backends remain compatible.
- Run the repository
makegate on the immutable candidate. - Compare default-flag performance against the exact parent using randomized paired eval STRING benchmark runs with operation counts/checksums; retain the split only when the paired interval shows a real improvement.
- Check representative non-eval workloads and startup/compilation cost so a faster eval benchmark does not hide a material regression elsewhere.
Related
- PR #2059: https://github.com/fglock/PerlOnJava/pull/2059
- Performance goal #1196: https://github.com/fglock/PerlOnJava/issues/1196
dev/bench/benchmark_eval_string.pl.agents/skills/profile-perlonjava/SKILL.md
- Lenguaje dominante
- Perl
- Estrellas
- 67
- Forks
- 8
- Merge medio
- 5 h 12 min
- PR fusionados (30 d)
- 131
Preparar el entorno
- Incluye un Dockerfile o un archivo de Docker Compose
- Sin plantilla de pull request
- Leer la guía de contribución
Primeros pasos
- Lee el issue completo y luego la guía de contribución del proyecto.
- Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
- Haz un fork del repositorio y trabaja en una rama.
- Abre un pull request que haga referencia al número del issue.
Más de fglock/PerlOnJava
-
area:cpan-port bug
Dificultad 2/5 1-3 horas Aptitud para principiantes 70/100
fglock/PerlOnJava#2153 ·
Los mantenedores suelen responder en 1 día
-
area:cpan-port area:parser bug
Dificultad 2/5 1-3 horas Aptitud para principiantes 68/100
fglock/PerlOnJava#2137 ·
Los mantenedores suelen responder en 1 día
-
area:backend area:cpan-port area:runtime bug
Dificultad 2/5 1-3 horas Aptitud para principiantes 76/100
fglock/PerlOnJava#2071 ·
Los mantenedores suelen responder en 1 día
-
area:runtime documentation enhancement
Dificultad 2/5 1-3 horas Aptitud para principiantes 72/100
fglock/PerlOnJava#1579 ·
Los mantenedores suelen responder en 1 día
-
area:cpan-port bug
Dificultad 3/5 1-2 días Aptitud para principiantes 62/100
fglock/PerlOnJava#2157 ·
Los mantenedores suelen responder en 1 día
Todos los issues de fglock/PerlOnJava
Issues similares
-
Dev-output directory preparation accepts file-valued lib/include paths and fails on dangling linksAbiertoteam-cli
Dificultad 2/5 1-3 horas Aptitud para principiantes 70/100
Los mantenedores suelen responder en 2 días
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 66/100
-
Dificultad 1/5 Menos de una hora Aptitud para principiantes 93/100
Los mantenedores suelen responder en 1 día
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 73/100
inverse-inc/packetfence#9728 ·
Los mantenedores suelen responder en 1 día
-
fix(char-create): show the real reason a character is refusedPosiblemente ocupada @baphomello la tomó hace 1 día. Abierto
Dificultad 2/5 1-3 horas Aptitud para principiantes 84/100
Los mantenedores suelen responder en 1 día