Cleanup follow-ups after #419: display-name delete proofs, legacy backfill, reason wording

Geschlossen
  • Stimmt etwas nicht?
#422 1 Kommentar 0 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen

Maintainer antworten meist innerhalb von 1 Tag

Dieses Issue hat noch niemand übernommen.

Bewertung

Schwierigkeit
4/5
Geschätzter Aufwand
3-5 Tage
Anfängerfreundlichkeit
22/100
Issue-Typ
Bug
Klarheit
Größtenteils klar
Aktivitätsstatus
Aktiv
Tech-Stack
go, kubernetes
Bereich
infrastructure

Rechercherichtung

Read the #419 diff first: it is the precedent for every item here. For item 1, follow the CoderAIProvider sweep for records without a provider ID and the CoderMCPServer live delete path; they should stop deleting on a display-name match and instead keep the record, emit coder_k8s_cleanup_records_unmatched and a ManualCleanupNeeded Event. Item 4 copies the MCP database-switch check so CoderAIProvider reports CoderDeploymentChanged rather than DeletedExternally. Items 2, 3 and 5 need the record/config linking logic before they can be scoped; item 6 is closed, so don't touch it.

Vom Indexierungsmodell aus dem Issue-Text verfasst.

Beschreibung

Cleanup gaps that remain after #419 (which fixes #353). Each one exists on main before #419 or is a documented limit of it. An independent verifier reproduced items 1 and 3 on main.

  1. Display-name proofs on delete. The CoderAIProvider sweep (for a record without a provider ID) and the CoderMCPServer live delete path still remove a resource whose display name matches the operator's temporary display name. Display names are editable in Coder, so a resource that a person renamed to that pattern can be removed. #413 and #419 adopted the rule "a record without a recorded ID never deletes" for provisioner keys and the MCP sweep. Apply the same rule here: keep the record, surface it (coder_k8s_cleanup_records_unmatched, ManualCleanupNeeded Event), and document manual cleanup.
  2. An MCP config whose slug and display name were both edited after a lost create answer has nothing left that links it to its record. The sweep drops the record and the config stays in Coder.
  3. Legacy-config backfill. A config made by an older operator version can end up without a record. This happens when the buildinfo read or the record write fails, and then the DELETE fails during the one bounded delete attempt while the control plane is being deleted. Codex thread: https://github.com/coder/coder-k8s/pull/419#discussion_r4427958297
  4. CoderAIProvider reports DeletedExternally after a database switch, where CoderMCPServer now reports CoderDeploymentChanged. Nothing leaks, but the reason misleads. Copy the MCP check.
  5. An MCP server whose status lost its config ID stalls with SlugConflict on its own config. Its delete still uses the recorded ID.
  6. #362 items 1 and 4 are closed by decision: the control plane hold never ends early, because no signal proves that no dependent cleanup is in flight. Two attempts in #410 were rejected for this reason. Reopen only with such a signal.

Refs #353, #419, #410

Generated with xum • Model: anthropic:claude-opus-5-5 • Thinking: high

Vorherrschende Sprache
Go
Sterne
5
Forks
3
Ø Merge
2 Std. 50 Min.
Gemergte PRs (30 T.)
200

Entwicklungsumgebung

Erste Schritte

  1. Lesen Sie das ganze Issue und danach den Beitragsleitfaden des Projekts.
  2. Schreiben Sie ins Issue, dass Sie es übernehmen — das erspart doppelte Arbeit.
  3. Forken Sie das Repository und arbeiten Sie in einem Branch.
  4. Öffnen Sie einen Pull Request, der die Issue-Nummer nennt.

Mehr aus coder/coder-k8s

Alle Issues in coder/coder-k8s

Ähnliche Issues

Weitere Issues zu Go

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.